Commit graph

905 commits

Author SHA1 Message Date
jedarden
4c5b75322b Merge branch 'main' of https://git.ardenone.com/jedarden/spaxel 2026-07-06 01:03:33 -04:00
jedarden
08ae674967 Add TypeScript type definitions for blob identity fields
Add TypeScript interface definitions for blob and related data structures,
including new identity resolution fields (personName, assignedColor, identityResolved).

Reference: bf-2186

- Created types/spaxel.d.ts with comprehensive type definitions
- Added Blob interface with identity fields (personName, assignedColor, identityResolved)
- All new fields typed as optional for backward compatibility
- Added JSDoc comments explaining each field
- Includes type definitions for all major dashboard data structures (Node, Zone, Alert, etc.)
- Maintained legacy fields (personLabel, personColor) with @deprecated tags

Co-Authored-By: Claude <noreply@anthropic.com>
2026-07-06 01:03:27 -04:00
jedarden
42eb6dcfa0 docs(bf-13s0): document blob data structure definition and usage patterns
- Located primary blob structure definition in backend Go code
- Identified all frontend files that create or use blob data
- Documented current blob structure fields (position, velocity, trail, identity)
- Specified which TypeScript interface/type files to modify (none - implicit JS structure)
- Created comprehensive reference for blob data structure modifications

Bead-Id: bf-13s0
2026-07-06 01:01:33 -04:00
jedarden
d12745ac93 docs(bf-13s0): document blob data structure definition and usage patterns
- Located primary blob structure definition in backend Go code
- Identified all frontend files that create or use blob data
- Documented current blob structure fields (position, velocity, trail, identity)
- Specified which TypeScript interface/type files to modify (none - implicit JS structure)
- Created comprehensive reference for blob data structure modifications
2026-07-06 01:01:17 -04:00
jedarden
ca77eec03a docs(bf-13s0): document blob data structure definition and usage patterns
- Located primary blob structure in state.js
- Identified all blob fields across the codebase
- Documented 3D and 2D rendering pipelines
- Listed key files and data flow
- Provided modification points for future changes
2026-07-06 00:58:57 -04:00
jedarden
040c01d17b docs(bf-3y9r): verify position propagation through registry and fusion engine
Complete trace of position propagation pipeline from simulator to
registry to fusion engine. All wiring is in place and functioning:
- Virtual nodes announce positions in hello messages (cmd/sim)
- Fleet manager persists positions to registry (internal/fleet)
- Positions are forwarded to fusion engine via sink (main.go)
- Fusion engine uses positions in each Fuse cycle (internal/fusion)
- Startup seeding and assertions confirm proper flow

Acceptance criteria verified:
✓ Positions from virtual node creation reach registry
✓ Positions from registry reach fusion engine
✓ Integration tests show positions flowing through all stages
✓ No missing glue found - pipeline complete from prior work

Co-Authored-By: Claude <noreply@anthropic.com>
2026-07-06 00:58:57 -04:00
jedarden
23d048d46c docs(bf-5yff): verify realistic node geometry implementation
Verify that virtual node creation uses the bf-195o design for realistic
geometry placement. The implementation is complete:

- API handler assigns spread positions for nodes created at (0,0,0)
- Registry bridge reassigns positions for nodes at default origin (0,0,1)
- Both use DefaultNodePositions() with grid layout and height diversity
- Positions properly sync to PosX/PosY/PosZ fields in the registry

No code changes required — the implementation was already complete
from prior work on bf-195o and the registry bridge architecture.

Co-Authored-By: Claude <noreply@anthropic.com>
2026-07-06 00:46:45 -04:00
jedarden
3936ae1182 docs(bf-195o): document node geometry placement research and design 2026-07-06 00:44:23 -04:00
jedarden
de03f33ba5 docs(bf-6aif): add accessibility quality gate implementation notes
Document the CI accessibility gate implementation, including changes made
to both declarative-config and spaxel repos, acceptance criteria met,
and verification steps.
2026-07-06 00:32:32 -04:00
jedarden
a7db9314b4 docs(ci): add accessibility quality gate documentation
Add CI accessibility testing guide documenting the WCAG 2.1 AA quality gate
that blocks releases on accessibility violations. Update main README to
reference the new documentation and clarify that accessibility tests are
a CI gate, not just local development tools.

This completes the accessibility quality gate requirement.
2026-07-06 00:32:03 -04:00
jedarden
8df33f8c90 feat(bf-5rre): add accessibility tests for onboarding flow
Add axe-core accessibility tests for the onboarding UI flow. Tests walk
through the onboarding steps and scan for WCAG 2.1 AA violations at each
step.

- Tests cover main onboarding flow steps (connect, WiFi, placement, complete)
- Tests cover re-provision mode and error states
- Tests mock hardware APIs (Web Serial, WebSocket) to avoid dependencies
- Each test fails if WCAG 2.1 AA violations are found
- Tests can be run with: npx playwright test a11y-onboarding

Co-Authored-By: Claude <noreply@anthropic.com>
2026-07-06 00:29:42 -04:00
jedarden
35763e96fe feat(bf-2adi): add accessibility tests for dashboard pages
Add axe-core Playwright tests for all 4 dashboard pages:
- ambient.html
- live.html
- simple.html
- simulator.html

Each test navigates to the page and scans for WCAG 2.1 AA violations.
Tests fail if any violations are found, ensuring accessibility compliance.

Co-Authored-By: Claude <noreply@anthropic.com>
2026-07-06 00:27:30 -04:00
jedarden
fb6e81e135 feat(bf-21nd): add axe-core Playwright integration with shared helper
- Add shared accessibility test helper (tests/accessibility/helper.js/ts)
  - scanAccessibility(): runs axe-core scans with WCAG 2.1 AA tags
  - formatViolations(): formats violation details for error reporting
  - expectNoAccessibilityViolations(): asserts no violations
- Add smoke tests demonstrating helper usage (tests/accessibility/smoke.spec.js/ts)
- Refactor existing accessibility tests to use shared helper
  - Simplified a11y.spec.js to use expectNoAccessibilityViolations()
  - Maintains all existing test coverage

Co-Authored-By: Claude <noreply@anthropic.com>
2026-07-06 00:25:52 -04:00
jedarden
669d3793aa feat(bf-18yn): seed realistic node geometry in spaxel-sim default placement
- Modify AddNode handler to assign spread-out positions when nodes are
  created without explicit positions (at origin), preventing co-location
  that causes Fresnel excess path |P-T|+|P-R|-|T-R| to collapse toward 0
- Use DefaultNodePositions infrastructure from simulator package to
  distribute nodes across the room in a grid pattern
- Preserve explicitly-set positions, only spread default-origin nodes
- Add tests verifying spread behavior and explicit position preservation

This fixes the core symptom in bf-4q5w where co-located nodes prevented
blob formation in the fusion accumulation grid.

Co-Authored-By: Claude <noreply@anthropic.com>
2026-07-06 00:25:52 -04:00
jedarden
4fe25fcfaf docs(bf-3ukb): verify crowd flow API path is in sync across all layers
Investigation confirmed that the crowd flow API path mismatch was already
resolved by commit f042cdf (which closed bf-2jyk). All three layers are
now consistent:
- Backend: /api/analytics/flow
- Frontend: /api/analytics/flow
- Plan spec: /api/analytics/flow

No code changes needed. This commit documents the verification.
2026-07-06 00:13:27 -04:00
jedarden
d00799593a docs(plan): fix API path for crowd flow endpoint
Update plan spec from /api/flow to /api/analytics/flow to match the actual implementation in both the Go backend and dashboard JavaScript.

Resolves bf-2jyk
2026-07-06 00:09:54 -04:00
jedarden
0a88630612 docs(bf-1oj7): verify TransformControls already implemented for live nodes
Analysis confirms that the Placement module already provides full TransformControls
functionality for dragging live registered nodes in the operational dashboard.

Key findings:
- Placement module initialized in app.js (line 285-287)
- TransformControls created and attached to any node mesh (placement.js:238-288)
- Position persistence via mothership API (placement.js:419-427)
- Node meshes created by Viz3D from registry_state (viz3d.js:263-294)

The pre-deployment simulator uses its own separate TransformControls (simulate.js),
which may have created the impression that the live dashboard lacked this feature.

No implementation changes needed - functionality is already operational.
2026-07-05 23:48:18 -04:00
jedarden
4a19fe9054 docs(bf-28dv): verify Component 24 already implemented 2026-07-05 23:18:41 -04:00
jedarden
9c36b0dab3 feat(bf-28dv): implement zone-aware rate control (Component 24)
Implement fleet-level sentinel link coordination with zone-aware idle modes:

- Zone membership tracking: Track which nodes belong to which zones and update zone state on motion events
- Zone idle detection: Detect when all nodes in a zone have been idle and designate one sentinel link per zone at 5 Hz
- Sentinel designation: Lexicographically smallest MAC becomes sentinel (5 Hz), others drop to 1 Hz
- Fleet idle coordination: When all zones are idle, only sentinel links run at 5 Hz for minimal bandwidth
- Adjacent zone ramping: When motion detected in a zone, ramp adjacent zones to 5 Hz for preemptive coverage
- RampZone() method: Interface for prediction engine to preemptively ramp zones when P(arrival) > threshold
- Zone-aware tests: Comprehensive tests for zone membership, idle detection, sentinel designation, fleet coordination, and backward compatibility

Co-Authored-By: Claude <noreply@anthropic.com>
2026-07-05 23:16:08 -04:00
jedarden
e13b2e220b docs(bf-33za): verify Component 33 already implemented
Verified that the 5-step interactive onboarding wizard is fully
implemented in dashboard/js/onboard.js:

- Step 1 (30s): Walk phase with amplitude spike highlighting
- Step 2 (10s): Still phase with automatic baseline capture
- Step 3 (15s): Walk-through with Fresnel zone visualization
- Step 4 (15s): Find-me with blob polling and humanoid display
- Step 5 (30s): Interactive placement with GDOP coverage overlay

All narration is jargon-free (no CSI, Fresnel, deltaRMS in user text).
All durations match spec. All 3D integrations working.
2026-07-05 23:00:59 -04:00
jedarden
3885fddbd8 docs(notes): correct acceptance-test file count in spaxel-build inventory (bf-1yeh)
mothership/test/acceptance/ has 7 as*_test.go files (as1..as7), not 9.
Total .go files = 10 (7 as* + integration_test + io_install_upgrade_test
+ test_helpers). Verified by ls.

Co-Authored-By: Claude <noreply@anthropic.com>
2026-07-04 09:36:38 -04:00
jedarden
2f12a4d1d1 docs(notes): add spaxel-build WorkflowTemplate path inventory (bf-1yeh)
Appendix A to ci-test-sim-reference-map.md: line-by-line path inventory
of the spaxel-build WorkflowTemplate. Every Go step runs with cwd=mothership,
so ./cmd/sim (L385), ./cmd/mothership (L392), and ./test/acceptance/ (L400)
all resolve under the mothership module. Confirms the template references
none of: root cmd/sim, root test/acceptance, tests/e2e/run.sh, or
mothership/tests/e2e/e2e_test.go (the latter only transitively compile-
covered by go test ./...).

Co-Authored-By: Claude <noreply@anthropic.com>
2026-07-04 09:17:14 -04:00
jedarden
8004d88322 ci: retire GitHub Actions workflows (benchmark-ci.yml, e2e.yml)
Argo Workflows (iad-ci) covers both jobs: the fusion-loop timing benchmark
runs as a FAIL	. [setup failed] step in the spaxel-build
WorkflowTemplate, and e2e/acceptance suites run via the spaxel-e2e template.
The two .github/workflows/*.yml files were redundant dead config that
suggested re-enabling GitHub Actions, which are disabled across all repos.

- Delete .github/workflows/benchmark-ci.yml and e2e.yml (and the now-empty
  .github/workflows + .github directories)
- docs/ci-benchmark-integration.md: drop the 'GitHub Actions Integration'
  section; note the benchmark step already exists in the spaxel-build
  template and that Argo is the only CI path

Co-Authored-By: Claude <noreply@anthropic.com>
2026-07-04 07:44:33 -04:00
jedarden
e0b91e695a chore(beads): close bf-5wky — dashboard npm prerequisites verified
Some checks failed
CI Benchmark - Fusion Loop Timing / Fusion Loop Timing Benchmark (push) Has been cancelled
Discovery only (no source changes). Confirmed dashboard/ is an npm project
(package.json: spaxel-dashboard) with package-lock.json present
(lockfileVersion 3, 361 packages) — npm ci prerequisite met. Toolchain:
node v20.19.2, npm 9.2.0. Recorded in comment #68.

Co-Authored-By: Claude <noreply@anthropic.com>
2026-07-04 07:39:03 -04:00
jedarden
42cd7939ae test(signal): harden PhaseSanitize property test, add collinear edge case (bf-nzev)
Some checks are pending
CI Benchmark - Fusion Loop Timing / Fusion Loop Timing Benchmark (push) Waiting to run
Add the collinear I/Q edge case (samples on a single line through the
origin, straddling the +-pi unwrap boundary) to the table-driven property
test, covering the last enumerated edge input from the plan's testing
strategy. Tighten the property loop so an unexpected error on a valid
edge case fails the test instead of being silently logged and passed.
No native fuzz target; runs green and fast under plain 'go test ./...'.

Co-Authored-By: Claude <noreply@anthropic.com>
2026-07-04 05:27:35 -04:00
jedarden
86b317b5c6 fix(dashboard): populate active link count in calibration_complete event (bf-5ba)
Some checks are pending
CI Benchmark - Fusion Loop Timing / Fusion Loop Timing Benchmark (push) Waiting to run
The calibration_complete WebSocket event sent to the guided-troubleshooting
dashboard hardcoded links: 0. Read the actual count of active links from the
ingestion server via GetAllLinksInfo() (the same source the dashboard snapshot
uses for its links list) so the post-calibration display reflects reality.

Co-Authored-By: Claude <noreply@anthropic.com>
2026-07-04 04:38:48 -04:00
jedarden
47caab4568 feat(api): wire build-time version through StatusHandler (bf-iekf)
Some checks are pending
CI Benchmark - Fusion Loop Timing / Fusion Loop Timing Benchmark (push) Waiting to run
Replace the hardcoded "1.0.0" literal in GET /api/status with the
build-time version var. Add a version field to StatusHandler, extend
NewStatusHandler to accept it, and pass the existing main.version
ldflag var at the call site. Add table-driven handler tests.
2026-07-04 04:29:59 -04:00
jedarden
cc24a1cf23 test(runner): document C11 7.13.2.1 setjmp clobber audit at call site (bf-31rd)
Relocate the per-variable setjmp/longjmp clobber analysis to the setjmp call
site and expand it into a full boundary audit per C11 7.13.2.1: enumerate every
automatic in scope (the loop index i; confirm there are no local tallies and
that g_failure_count/g_test_jmp are file-scope static, to which 7.13.2.1 does
not apply), and show why each is determinate — i is written only by the for-init
and for-increment, the latter running after control resumes, so no write lands
between setjmp and a longjmp fired in the body.

volatile on i is retained: the standard does not strictly require it (i is not
changed in the window), but gcc's -Wclobbered is heuristic and ignores that
distinction — empirically verified that the loop warns at -O1..-Os once the
incidental preceding qsort() stops biasing the register heuristic. volatile is
the sanctioned suppression. Compile gate confirmed clean at -O0..-Os with
-Wall -Wextra and explicit -Wclobbered; full suite still 29 RUN / 0 FAIL.

Analysis + comment + build verification only; no behavior change vs bf-22vg.

Co-Authored-By: Claude <noreply@anthropic.com>
2026-07-04 04:29:59 -04:00
jedarden
f254c8583a test(runner): record per-test RUN-line isolation confirmation (bf-50yh)
Some checks are pending
CI Benchmark - Fusion Loop Timing / Fusion Loop Timing Benchmark (push) Waiting to run
Document the dynamic confirmation that the recovery loop prints exactly one
RUN: line per registered test and drives the whole suite. Captured stdout of a
successful `make -C firmware/test test` run: 29 registered TEST() definitions,
29 RUN lines emitted, bidirectional set diff identical (none skipped, none
duplicated). Emitted order is byte-for-byte strcmp-sorted (qsort-by-name), as
expected for the all-passing suite where every body returns normally — no
FAIL/stderr interleaving. RUN-line set and order unchanged vs the naive
direct-call baseline (bf-1fd4). Satisfies umbrella bf-tof1 / parent bf-22vg.

Co-Authored-By: Claude <noreply@anthropic.com>
2026-07-04 02:29:01 -04:00
jedarden
7b6a3d89b2 test(runner): volatile-qualify setjmp loop index for -Wclobbered-clean build (bf-2k3o)
The per-test loop in main() spans the setjmp(g_test_jmp)/longjmp recovery
target: i is read (loop test + increment) on the longjmp-return path. gcc's
-Wclobbered (enabled under -Wall) flags exactly this loop-index-across-setjmp
shape. The build was clean today only coincidentally — the preceding qsort()
call biases gcc's register heuristic; an identical loop without it warns at
-O1/-O2 (verified). Qualify i as volatile per C11 7.13.2.1, the sanctioned
remedy (no pragma, no flag downgrade), with no behavior change. This is the
compile-cleanliness gate for the guard (parent bf-22vg).

Verified: gcc -std=c11 -Wall -Wextra -Wclobbered -Werror is clean at
-O0/-O1/-O2/-O3/-Os/-Og; make -C firmware/test test builds warning-free and
runs all 30 tests (exit 0). Only firmware/test/test_runner.c touched.

Co-Authored-By: Claude <noreply@anthropic.com>
2026-07-04 02:29:01 -04:00
jedarden
b62fa3ed60 test(runner): gate test body on setjmp(g_test_jmp) recovery target (bf-27ud)
Some checks are pending
CI Benchmark - Fusion Loop Timing / Fusion Loop Timing Benchmark (push) Waiting to run
Wrap the per-test g_tests[i].fn() call in if (setjmp(g_test_jmp) == 0),
establishing the longjmp recovery target declared in bf-3id before each
test runs. The RUN: printf stays before the setjmp so the per-test marker
still prints regardless of how the body ends; the non-zero (longjmp) path
falls through with no else body, so the loop's i++ still advances and a
failure in test N never blocks N+1..end.

PASS/FAIL labels, tallies, summary, and non-zero exit remain sibling scope
(child 3, bf-1na) — main() still returns 0 unconditionally here.

Co-Authored-By: Claude <noreply@anthropic.com>
2026-07-03 20:49:56 -04:00
jedarden
2eab19b6e0 Merge remote-tracking branch 'origin/main'
Some checks are pending
CI Benchmark - Fusion Loop Timing / Fusion Loop Timing Benchmark (push) Waiting to run
2026-07-03 20:29:43 -04:00
jedarden
6a2d1406c9 test(runner): strip main() to naive direct-call baseline (bf-1fd4) 2026-07-03 20:25:54 -04:00
jedarden
1df0bfaa21 test(fusion): assert default-placement produces non-zero peaks (bf-1kid)
Some checks are pending
CI Benchmark - Fusion Loop Timing / Fusion Loop Timing Benchmark (push) Waiting to run
The bf-18yn umbrella's acceptance-criteria test. Using ONLY the default
node placement (simulator.DefaultNodePositions — the spread geometry a
freshly-onboarded virtual/sim fleet receives with no manual positioning,
bf-3fr6/bf-xrej), seed the 3D fusion engine and assert the accumulation
grid produces non-zero fusion peaks, closing the bf-4q5w symptom (the
engine emitting no / degenerate peaks).

TestEngine_DefaultPlacementProducesPeaks is the fleet->engine counterpart
to TestEngine_SeedNodePositions (bf-6s3d): bf-6s3d locks in the seeding
invariant (distinct, non-(0,0,1) positions); this locks in the downstream
consequence the seeding exists to deliver — that spread nodes actually
let Fuse form blobs. It runs over default placements of 2/3/4/6 nodes,
drives a synthetic walker through the room centre, and asserts
len(blobs) > 0 OR gridMax above threshold. assertPlacementNotCollapsed
fails loudly if default placement ever collapses to (0,0,1).

TestEngine_CoLocatedOriginYieldsNoPeaks is the counter-example pinning
bf-4q5w: nodes left at the (0,0,1) DB default are co-located, every link
is degenerate, the grid stays at zero, and Fuse emits no blobs — proving
the non-zero-peak assertion is meaningful, not trivially satisfiable.

Acceptance: passes with default placement; co-located (0,0,1) collapse
yields no peaks (documented by the counter-example). go build ./... /
go vet ./... / go test ./... all pass across mothership, cmd/sim, and
test/acceptance.

Co-Authored-By: Claude <noreply@anthropic.com>
Bead-Id: bf-1kid
2026-07-03 19:18:46 -04:00
jedarden
307ab0e194 feat(simulator): seed spread geometry for default virtual nodes in registry bridge (bf-xrej)
Some checks are pending
CI Benchmark - Fusion Loop Timing / Fusion Loop Timing Benchmark (push) Waiting to run
Virtual nodes created without an explicit position carry the nodes-table DB
defaults (pos_x=0, pos_y=0, pos_z=1), so SyncToRegistry/SyncOneNode wrote
co-located origin positions into the fleet registry — and downstream into the
fusion engine — collapsing Fresnel excess paths (core symptom in bf-18yn).

Resolve positions through a new effectivePositions helper: nodes still at the
default origin are reassigned distinct, spread-out geometry from
DefaultNodePositions (sized to the full node count, across the store's space),
while explicitly-placed nodes keep their position. Slot assignment is keyed by
sorted node ID so it is deterministic regardless of map iteration order, and a
single-node sync writes the same position a full sync would. The effective
positions flow through SyncToRegistry, SyncOneNode, and ToRegistryRecords, so
the registry and fusion-engine seeding observe non-degenerate geometry.

Co-Authored-By: Claude <noreply@anthropic.com>
2026-07-03 19:00:37 -04:00
jedarden
d048987d61 feat(ingestion): persist hello-announced node position in fleet registry (bf-24xp)
Some checks are pending
CI Benchmark - Fusion Loop Timing / Fusion Loop Timing Benchmark (push) Waiting to run
spaxel-sim computed good corner/perimeter geometry in createVirtualNodes but
the hello message sent on WebSocket connect did not include position, so the
mothership never learned the sim node's location and the fleet registry/DB row
was left at the nodes-table schema default (0,0,1) — co-located with every
other node.

Both sim CLIs (cmd/sim and mothership/cmd/sim) now announce pos_x/pos_y/pos_z
in the hello handshake, sourced from createVirtualNodes. HelloMessage gains
PosX/PosY/PosZ as *float64 (not plain float64) so an absent position is
distinguishable from a genuine (0,0,0): a real ESP32 omits these in hello
(its position is user-placed in the dashboard), whereas spaxel-sim announces
its computed geometry.

The connect/register path (server.HandleNodeWS -> FleetNotifier.OnNodeConnected
-> fleet.Manager) now carries the announced position through. The Manager
persists it via registry.SetNodePosition only when all three axes are present,
so a nil/partial announcement preserves any existing user-placed position
rather than clobbering it. The position then flows onward to the fusion engine
through the bf-3p6g connect/register sink (ForwardNodePosition ->
nodePositionSink -> fusionEngine.SetNodePosition), so a freshly connected sim
node is seeded at its announced location instead of (0,0,1).

The FleetNotifier interface change (OnNodeConnected gains three *float64
params) is propagated to every implementer — Manager (persists), FleetHealer
and SelfHealManager (read geometry from the registry, ignore), the guided-
troubleshoot notifier (tracks connect/disconnect only), and the cmd/mothership
multiFleetNotifier fan-out.

Tests: existing OnNodeConnected call sites updated to the new signature.
TestManagerOnNodeConnectedPersistsHelloPosition asserts a node connecting with
an announced position yields a registry row whose pos differs from (0,0,1) and
matches the sent coordinates, and that the same coordinates reach the fusion
engine. TestManagerOnNodeConnectedWithoutHelloPositionPreservesExisting
asserts the real-ESP32 case (nil announce) and partial-announce both leave an
existing user-placed position untouched.

Co-Authored-By: Claude <noreply@anthropic.com>
2026-07-03 18:42:34 -04:00
jedarden
3ba6f25fab Merge remote-tracking branch 'origin/main'
Bead-Id: bf-38e9
2026-07-03 18:33:38 -04:00
jedarden
3d53616594 Merge remote-tracking branch 'origin/main'
Some checks are pending
CI Benchmark - Fusion Loop Timing / Fusion Loop Timing Benchmark (push) Waiting to run
2026-07-03 18:30:34 -04:00
jedarden
eb4ad31aae Merge remote-tracking branch 'origin/main' 2026-07-03 18:29:36 -04:00
jedarden
1f3e39a6c5 feat(simulator): add shared DefaultNodePositions helper for spread node geometry (bf-3fr6)
Some checks are pending
CI Benchmark - Fusion Loop Timing / Fusion Loop Timing Benchmark (push) Waiting to run
2026-07-03 18:18:39 -04:00
jedarden
a17bdd2c8c feat(fusion): propagate runtime node positions to the fusion engine (bf-3p6g)
Some checks are pending
CI Benchmark - Fusion Loop Timing / Fusion Loop Timing Benchmark (push) Waiting to run
Forward node 3D position changes to the blob-producing fusion engine so a
node moved at runtime does not keep a stale engine position. The fleet
manager gains a nodePositionSink — the write-side mirror of the read-side
SetNodePositionAccessor used by diagnostics and weather.go — wired to
fusionEngine.SetNodePosition at startup. It fires from both position paths:
PATCH /api/nodes/{mac}/position (handler.updateNodePosition →
ForwardNodePosition) and node connect/register (OnNodeConnected forwards the
registry position). Tests assert the engine's stored position for a MAC
changes after a PATCH with new coordinates and is seeded on connect.

Co-Authored-By: Claude <noreply@anthropic.com>
2026-07-03 17:31:40 -04:00
jedarden
3785619967 feat(fusion): assert engine node positions at startup (bf-1tsm)
Some checks are pending
CI Benchmark - Fusion Loop Timing / Fusion Loop Timing Benchmark (push) Waiting to run
bf-6s3d added TestEngine_SeedNodePositions, the host/unit-test half of
the node-position invariant (it replays main.go's seeding loop against
the engine and asserts NodeCount()/NodePositions() hold distinct,
non-(0,0,1) positions). This bead adds the complementary half the
NodePositions() docstring (fusion.go:140-159) already advertises:
"a logged startup assertion" exercised in the live path.

Right after the main.go seeding loop (which calls
fusionEngine.SetNodePosition(node.MAC, node.PosX, node.PosY, node.PosZ)
per fleet node), the engine now inspects NodePositions() and logs:

- n == 0          → INFO  "no nodes positioned yet" (valid; IO-1 reaches
                              ready with no nodes attached)
- atDefault == n  → WARN  "all N seeded nodes collapsed to (0,0,1)"
                             (fleet never positioned → degenerate fusion)
- otherwise       → INFO  "N nodes seeded, D distinct, A at (0,0,1)"

The (0,0,1) collapse is the failure mode: when no node has been
positioned, every node retains the nodes-table schema default
(pos_x=0, pos_y=0, pos_z=1) and Fuse emits only degenerate peaks. The
assertion surfaces this without blocking startup (the hard gate stays
the bf-6s3d unit test).

Also gofmt's the file (drive-by): bf-3f6q's "fusion" import sat after
"ingestion" instead of alphabetically after "floorplan".

go build ./... / go vet ./... / go test ./... all pass; gofmt clean.

Co-Authored-By: Claude <noreply@anthropic.com>
Bead-Id: bf-1tsm
2026-07-03 16:54:15 -04:00
jedarden
ce86575df4 test(fusion): lock in fleet→engine node-seeding invariant (bf-6s3d)
Some checks are pending
CI Benchmark - Fusion Loop Timing / Fusion Loop Timing Benchmark (push) Waiting to run
The 3D fusion engine's startup node seeding (iterate
fleetReg.GetAllNodes() and call SetNodePosition(node.MAC, node.PosX,
node.PosY, node.PosZ) per node, reading the DB pos_x/pos_y/pos_z
columns) was already wired into the live path by bf-3f6q (main.go
seeding loop sits symmetrically with the selfImprovingLocalizer
seeding). This bead's contribution is a regression test codifying the
bf-6s3d acceptance criteria so a future refactor cannot silently
regress them:

- NodeCount() equals the number of fleet nodes returned by GetAllNodes()
- NodePositions() holds a distinct, non-(0,0,1) position for each
  registered node (nodes must NOT collapse to the co-located DB
  default of pos_x=0, pos_y=0, pos_z=1)

TestEngine_SeedNodePositions replays the main.go seeding pattern
against the engine and asserts all three invariants (count, exact
coordinate round-trip, distinctness, non-default).

go build ./... / go vet ./... / go test ./... all pass.

Co-Authored-By: Claude <noreply@anthropic.com>
Bead-Id: bf-6s3d
2026-07-03 16:42:09 -04:00
jedarden
30a7ea346e feat(fusion): construct 3D fusion engine in live path and feed the blob loop (bf-3f6q)
Some checks are pending
CI Benchmark - Fusion Loop Timing / Fusion Loop Timing Benchmark (push) Waiting to run
The 3D Fresnel fusion engine (internal/fusion.NewEngine) was only ever
constructed in tests (bf-2fz8), so pm.trackedBlobs was always nil — every
GetTrackedBlobs() reader (live loop, /api/blobs, anomaly adapter, API
wrappers) saw zero blobs and IO-6 could never pass.

Wire the engine into the live 10 Hz loop:
- Construct fusion.NewEngine at startup with a Config mirroring room geometry
  (Width/Height/Depth/Origin from the fleet room config), as a function-local
  retained for the life of main (mirrors selfImprovingLocalizer) so startup
  seeding and the follow-up node-seeding bead can call SetNodePosition on it
  and the live-loop closure captures it for Fuse each tick.
- Seed its node registry from the fleet at startup (without positioned nodes,
  Fuse skips every link).
- In the tracker goroutine, replace the dead pm.GetTrackedBlobs() read with
  fusionEngine.Fuse(gatherFusionLinks(pm)) -> blobTracker.track(result) ->
  pm.SetTrackedBlobs(blobs). The new blobTracker bridges the engine's
  stateless peaks to stateful sigproc.TrackedBlob IDs via greedy 1.0 m
  nearest-neighbour association (plan.md Component 4) and derives velocity
  from the previous position of the same tracked ID.

go build ./... / go vet ./... / go test ./... all pass.

Co-Authored-By: Claude <noreply@anthropic.com>
2026-07-03 16:33:26 -04:00
jedarden
a7ec9d20b2 docs(signal): record bf-2fz8 finding — no engine feeds the live blob loop
Some checks are pending
CI Benchmark - Fusion Loop Timing / Fusion Loop Timing Benchmark (push) Waiting to run
Investigation (prereq for the bf-3gw1 umbrella) determining which fusion
engine produces the blobs consumed by the live 10 Hz loop and the IO-6 gate.

Verified findings (recorded as a doc comment on SetTrackedBlobs):
- pm.trackedBlobs is always nil: SetTrackedBlobs (signal/processor.go:625)
  has zero callers, so it is never invoked.
- Every GetTrackedBlobs reader therefore sees zero blobs — IO-6 ("walker
  produces a tracked blob") cannot pass. Read sites: live loop
  main.go:1866, /api/blobs main.go:4056, anomalyPositionAdapter main.go:4840,
  API wrappers internal/api/status.go:84 and internal/api/tracks.go:99.
- internal/fusion.NewEngine (3D Fresnel, internal/fusion/fusion.go:93) is
  NEVER constructed in non-test code; the internal/fusion package is imported
  by exactly one file, internal/localizer/fusion/timing_budget_test.go (a test).
- A second engine, internal/localization.NewEngine (2D Fresnel,
  internal/localization/fusion.go:53), IS constructed live via
  NewSelfImprovingLocalizer (main.go:1005) and runs Fuse (main.go:2593), but
  the returned *FusionResult is discarded — nothing reads .Peaks and no
  signal.TrackedBlob literal exists outside tests.

Conclusion: to satisfy IO-6, internal/fusion.NewEngine MUST be newly
constructed in non-test code and wired (Fuse -> TrackedBlob ->
SetTrackedBlobs), OR the existing localization.Engine FusionResult.Peaks must
be converted to TrackedBlobs and stored via SetTrackedBlobs.

Also adds fusion.Engine NodeCount()/NodePositions() accessors as scaffolding
for the umbrella's node-seeding verification.

Co-Authored-By: Claude <noreply@anthropic.com>
2026-07-03 16:09:41 -04:00
jedarden
d299306cb0 test: drop stale PASS/FAIL reference in host-harness loop comment
The per-test setjmp loop's doc comment still said it lands back in the
loop "to print PASS/FAIL and advance" — but child 1 (bf-52k2) and
child 2 (bf-344n) already replaced both branches' outcome labels with
the neutral RUN marker family ("RUN: <name>" / "RUN: <name>
(assertion failed)"). The comment now contradicts the code, so align
it with the "neutral marker line" phrasing already used lower in the
same block. No code change; gcc -std=c11 -Wall -Wextra still clean.

Co-Authored-By: Claude <noreply@anthropic.com>
Bead-Id: bf-344n
2026-07-03 14:55:47 -04:00
jedarden
ca1b51007d test: drop stale PASS/FAIL reference in host-harness loop comment
Some checks are pending
CI Benchmark - Fusion Loop Timing / Fusion Loop Timing Benchmark (push) Waiting to run
The per-test setjmp loop's doc comment still said it lands back in the
loop "to print PASS/FAIL and advance" — but child 1 (bf-52k2) and
child 2 (bf-344n) already replaced both branches' outcome labels with
the neutral RUN marker family ("RUN: <name>" / "RUN: <name>
(assertion failed)"). The comment now contradicts the code, so align
it with the "neutral marker line" phrasing already used lower in the
same block. No code change; gcc -std=c11 -Wall -Wextra still clean.

Co-Authored-By: Claude <noreply@anthropic.com>
2026-07-03 14:52:29 -04:00
jedarden
b86cb670a8 test: print neutral RUN marker on direct setjmp==0 path
Some checks are pending
CI Benchmark - Fusion Loop Timing / Fusion Loop Timing Benchmark (push) Waiting to run
The direct branch of main()'s per-test setjmp loop — taken when a test
runs normally without longjmping back — now prints "RUN: <name>" instead
of "PASS: <name>". This is the same neutral marker family child 1
(bf-52k2) chose for the else branch ("RUN: <name> (assertion failed)"),
so a passing test prints "RUN: <name>" and a failing test prints
"RUN: <name> (assertion failed)".

After this child, NEITHER branch emits PASS/FAIL; each test emits exactly
one neutral line. The internal passed++ counter is unchanged — it feeds
the run summary ("N passed, M failed of T"), not the per-test output, so
it is not an "observable label". g_failure_count accounting is likewise
untouched.

Child 2 of 4 for bf-38e9 (split-child 2 of bf-53ut).

Co-Authored-By: Claude <noreply@anthropic.com>
2026-07-03 14:01:29 -04:00
jedarden
d9d1048320 Merge origin/main into local test-runner work
Some checks are pending
CI Benchmark - Fusion Loop Timing / Fusion Loop Timing Benchmark (push) Waiting to run
Reconciles divergence: local 8fbc2e8 (volatile doc) and origin's
4b0eaba (same) plus 5e58859 (nvs/csi/serial_prov host tests + CI
wiring) and fbb86fb (gitignore). Clean merge: both branches agree on
test_runner.c content; origin additionally adds host tests and CI.
2026-07-03 13:37:38 -04:00
jedarden
6e454803fb test: print neutral RUN marker on longjmp failure-return branch
The else branch of main()'s per-test setjmp loop — taken when a failed
assertion longjmps back — now prints "RUN: <name> (assertion failed)"
instead of "FAIL: <name>". The marker still names the failing test and
its own per-test `failed` counter, but contains no PASS/FAIL outcome
token (outcome labels are deferred to a later sibling of bf-53ut).

g_failure_count accounting is unchanged: test_record_failure() already
bumped it before the longjmp, so this branch only prints.

Child 1 of 4 for bf-38e9 (split-child 2 of bf-53ut).

Co-Authored-By: Claude <noreply@anthropic.com>
2026-07-03 13:37:19 -04:00