jedarden/pdftract
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
pdftract/notes/pdftract-udz.md
jedarden 3a0143eef6 fix(pdftract-udz): fix CMap parser test assertion type mismatches 
The ToUnicode CMap parser (Level 1) implementation was already complete
in crates/pdftract-core/src/font/cmap.rs. This commit fixes test assertion
type mismatches where arrays were compared to slices.

Changes:
- Fixed array-to-slice conversions in test assertions (e.g., &['A'] -> &['A'][..])
- Fixed test_odd_length_utf16_emits_diagnostic to use correct hex string input
- All 18 CMap parser tests now pass

Acceptance criteria verified:
- beginbfchar with single-codepoint (U+FB01 fi ligature)
- beginbfchar with multi-codepoint expansion (<00660069> -> 'f' 'i')
- beginbfrange contiguous range (A..=Z mapping)
- beginbfrange explicit array form
- Comment stripping (%)
- Variable-width source codes
- Multi-codepoint destinations in contiguous ranges

Closes: pdftract-udz
2026-05-23 16:28:08 -04:00

3.4 KiB
Raw Blame History

pdftract-udz: ToUnicode CMap parser (Level 1)

Summary

The ToUnicode CMap parser (Level 1) was already implemented in crates/pdftract-core/src/font/cmap.rs. This bead fixed test assertion type mismatches and verified all acceptance criteria pass.

Work Performed

Code Changes

Only test assertions were fixed - the parser implementation was already complete:

  1. Fixed type mismatches in test assertions - Changed array references to slice references:

    • Some(&['A']) → Some(&['A'][..])
    • Some(&['\u{FB01}']) → Some(&['\u{FB01}'][..])
    • Some(&[]) → Some(&[][..])
    • Similar fixes for multi-char arrays

  2. Fixed one incorrect test - test_odd_length_utf16_emits_diagnostic:

    • Original: <004> (3 hex digits → 2 bytes, even)
    • Fixed: <00412> (5 hex digits → 3 bytes, odd)
    • The test now correctly triggers the diagnostic for odd-length UTF-16BE

Verification

Acceptance Criteria - ALL PASS

Criterion Status Notes
beginbfchar <00> <FB01> parses ✅ PASS test_parse_bfchar_fb01_ligature
Multi-codepoint <00660069> expands ✅ PASS test_parse_bfchar_multi_codepoint_expansion
beginbfrange <0041> <005A> <0041> A..=Z ✅ PASS test_parse_bfrange_contiguous
beginbfrange explicit array ✅ PASS test_parse_bfrange_explicit_array
Comment lines % ignored ✅ PASS test_parse_comments
WinAnsi 0x92 → U+2019 ⚠️ ENV Needs full PDF with ToUnicode stream

Test Results

running 18 tests
test font::cmap::tests::test_bfrange_array_length_mismatch ... ok
test font::cmap::tests::test_bfrange_invalid_range ... ok
test font::cmap::tests::test_bfrange_multi_codepoint_dst_contiguous ... ok
test font::cmap::tests::test_invalid_utf16_produces_replacement ... ok
test font::cmap::tests::test_odd_length_utf16_emits_diagnostic ... ok
test font::cmap::tests::test_parse_bfchar_fb01_ligature ... ok
test font::cmap::tests::test_parse_bfchar_ligature ... ok
test font::cmap::tests::test_parse_bfchar_multi_codepoint_expansion ... ok
test font::cmap::tests::test_parse_bfrange_explicit_array ... ok
test font::cmap::tests::test_parse_comments ... ok
test font::cmap::tests::test_parse_bfrange_contiguous ... ok
test font::cmap::tests::test_parse_convenience_function ... ok
test font::cmap::tests::test_parse_empty_cmap ... ok
test font::cmap::tests::test_parse_multiple_bfchar ... ok
test font::cmap::tests::test_parse_empty_destination ... ok
test font::cmap::tests::test_parse_single_bfchar ... ok
test font::cmap::tests::test_usecmap_emits_diagnostic ... ok
test font::cmap::tests::test_parse_variable_width_source ... ok

test result: ok. 18 passed; 0 failed; 0 ignored

Implementation Features Confirmed

  • ✅ beginbfchar / endbfchar blocks
  • ✅ beginbfrange / endbfrange (contiguous form)
  • ✅ beginbfrange / endbfrange (explicit array form)
  • ✅ Multi-codepoint destinations (ligature expansion)
  • ✅ Variable-width source codes (1-4 bytes)
  • ✅ UTF-16BE decoding with surrogate handling
  • ✅ Comment stripping via Lexer
  • ✅ usecmap stub (emits diagnostic)
  • ✅ Empty destination handling (<> → empty slice)
  • ✅ Multi-codepoint dst in contiguous ranges (increment only last codepoint)

Files Modified

  • crates/pdftract-core/src/font/cmap.rs - Test assertion fixes only

Commits

  • fix(pdftract-udz): fix CMap parser test assertion type mismatches