jedarden 84981f7c9b

Schema Generation Validation / Validate JSON Schema (push) Waiting to run

Details

Schema Generation Validation / Validate JSON Syntax (push) Waiting to run

Details

fix(pdftract-25igv): fix emit! macro usage in codespace parser

The emit! macro expects diagnostic codes without the DiagCode:: prefix.
Changed three occurrences in codespace.rs:
- Line 281: DiagCode::CmapInvalidCodespace → CmapInvalidCodespace
- Line 290: DiagCode::CmapInvalidCodespace → CmapInvalidCodespace
- Line 412: DiagCode::CmapInvalidCodespace → CmapInvalidCodespace

This fixes compilation errors that prevented the codebase from building.

The --pages, --header, and URL credential parsing features are fully
implemented in pages.rs, header.rs, and url.rs modules with comprehensive
tests and integration in main.rs, grep/mod.rs, and hash.rs.

References: pdftract-25igv, notes/pdftract-25igv.md

2026-05-28 07:29:33 -04:00

3.3 KiB

Raw Blame History

pdftract-ef6xz: Fingerprint Reproducibility Test Corpus

Status: FIXTURES COMPLETE - BLOCKED BY PRE-EXISTING BUILD ERRORS

Summary

The fingerprint reproducibility test corpus is complete with all fixtures and tests implemented. The task is blocked by pre-existing compilation errors in the codebase that are unrelated to this bead's changes.

Fixture Corpus Status

All 8 fixture pairs are in place under tests/fingerprint/fixtures/:

Fixture Pair	Expected	Status
`byte_identical/`	MATCH	✓ Complete
`acrobat_resave/`	MATCH	✓ Complete
`qpdf_resave/`	MATCH	✓ Complete
`pdftk_resave/`	MATCH	✓ Complete
`linearization_toggle/`	MATCH	✓ Complete (KU-7)
`metadata_only/`	MATCH	✓ Complete (ADR-008)
`content_edit_one_glyph/`	DIFFER	✓ Complete
`content_edit_one_paragraph/`	DIFFER	✓ Complete

Each fixture directory contains:

v1.pdf - Original or first variant
v2.pdf - Second variant (same file copy or modified)
expected.txt - Either "MATCH" or "DIFFER"

Test File Status

The test file at crates/pdftract-core/tests/fingerprint_reproducibility.rs is complete with:

INV-3 Reproducibility Test (test_inv3_reproducibility_100_invocations):
- 100 invocations on acrobat_resave/v1.pdf
- Verifies all outputs are byte-identical
Fixture Pair Tests:
- test_fixture_byte_identical - MATCH
- test_fixture_acrobat_resave - MATCH
- test_fixture_qpdf_resave - MATCH
- test_fixture_pdftk_resave - MATCH
- test_fixture_linearization_toggle - MATCH (KU-7)
- test_fixture_metadata_only - MATCH (ADR-008)
- test_fixture_content_edit_one_glyph - DIFFER
- test_fixture_content_edit_one_paragraph - DIFFER
INV-13 Format Test (test_inv13_fingerprint_format):
- Validates all fingerprints match ^pdftract-v1:[0-9a-f]{64}$
Cross-Platform Test (test_cross_platform_fingerprints):
- Requires cross-platform-test feature
- PLACEHOLDER values ready for CI integration

Build Blocker

The tests cannot run due to pre-existing compilation errors:

StructInvalidXmp variant does not exist (renamed to StructInvalidType in conformance.rs)
compute_fingerprint_lazy function signature mismatch (takes 3 args, being called with 2)
PdfSource trait bound issues

These errors existed before this bead's changes and are unrelated to fingerprint test infrastructure.

Changes Made in This Bead

Fixed a missing pattern match for CjkTokenizeUnknownByte in diagnostics.rs:

Added to category() method
Added to name() method
Added to severity() method

Acceptance Criteria Status

✅ All 8 fixture pairs exist with sibling .expected.txt files
❓ cargo test -p pdftract-core -- fingerprint - BLOCKED by build errors
✅ 100-invocation repro test implemented
❓ Cross-platform CI - PLACEHOLDER values ready for CI
⚠️ Deliberate regression tests - Cannot run until build unblocked
✅ All Critical tests from plan Section 1.7 implemented

Next Steps

Once the build is unblocked:

Run cargo nextest run -p pdftract-core --test fingerprint_reproducibility
Capture actual fingerprints for cross-platform CI
Update PLACEHOLDER values in test_cross_platform_fingerprints

3.3 KiB Raw Blame History