jedarden/miroir
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(release): strip quotes from Chart.yaml appVersion in release-ready-check

Browse source 
The appVersion field in Chart.yaml has quotes around the value (e.g.
appVersion: "0.1.0"), which the release-ready-check.sh script was
including in the parsed value. This caused false positive failures
when comparing Cargo.toml version (0.1.0) with Chart.yaml appVersion
("0.1.0").

Fix by piping to tr -d '"' to strip the quotes.

Closes: miroir-qjt.6 (P8.6 Release mechanics)

All release mechanics acceptance criteria verified:
- bump-version.sh atomically updates all 3 files
- miroir-release.yaml handles tag-triggered releases
- Pre-release tags skip :latest and float tags
- release-ready-check.sh now correctly validates version sync

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
jedarden 2026-05-25 00:09:16 -04:00
parent 9d29d757c7
commit 56585972ca
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
scripts/release-ready-check.sh
View file

@ -24,7 +24,7 @@ if [[ -n "$EXPECTED" && "$CARGO_VERSION" != "$EXPECTED" ]]; then
fi
CHART_VERSION=$(grep '^version: ' "$REPO_ROOT/charts/miroir/Chart.yaml" | sed 's/version: //')
APP_VERSION=$(grep '^appVersion: ' "$REPO_ROOT/charts/miroir/Chart.yaml" | sed 's/appVersion: //')
APP_VERSION=$(grep '^appVersion: ' "$REPO_ROOT/charts/miroir/Chart.yaml" | sed 's/appVersion: //' | tr -d '"')
if [[ "$CARGO_VERSION" != "$CHART_VERSION" ]]; then
echo "FAIL: Cargo.toml version ($CARGO_VERSION) != Chart.yaml version ($CHART_VERSION)" >&2