From 56585972ca844988f9d284de1b6e56bc4097cbae Mon Sep 17 00:00:00 2001 From: jedarden Date: Mon, 25 May 2026 00:09:16 -0400 Subject: [PATCH] fix(release): strip quotes from Chart.yaml appVersion in release-ready-check The appVersion field in Chart.yaml has quotes around the value (e.g. appVersion: "0.1.0"), which the release-ready-check.sh script was including in the parsed value. This caused false positive failures when comparing Cargo.toml version (0.1.0) with Chart.yaml appVersion ("0.1.0"). Fix by piping to tr -d '"' to strip the quotes. Closes: miroir-qjt.6 (P8.6 Release mechanics) All release mechanics acceptance criteria verified: - bump-version.sh atomically updates all 3 files - miroir-release.yaml handles tag-triggered releases - Pre-release tags skip :latest and float tags - release-ready-check.sh now correctly validates version sync Co-Authored-By: Claude Opus 4.7 --- scripts/release-ready-check.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/release-ready-check.sh b/scripts/release-ready-check.sh index a6b02a1..c5aff8c 100755 --- a/scripts/release-ready-check.sh +++ b/scripts/release-ready-check.sh @@ -24,7 +24,7 @@ if [[ -n "$EXPECTED" && "$CARGO_VERSION" != "$EXPECTED" ]]; then fi CHART_VERSION=$(grep '^version: ' "$REPO_ROOT/charts/miroir/Chart.yaml" | sed 's/version: //') -APP_VERSION=$(grep '^appVersion: ' "$REPO_ROOT/charts/miroir/Chart.yaml" | sed 's/appVersion: //') +APP_VERSION=$(grep '^appVersion: ' "$REPO_ROOT/charts/miroir/Chart.yaml" | sed 's/appVersion: //' | tr -d '"') if [[ "$CARGO_VERSION" != "$CHART_VERSION" ]]; then echo "FAIL: Cargo.toml version ($CARGO_VERSION) != Chart.yaml version ($CHART_VERSION)" >&2