jedarden/ai-code-battle
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(engine): resolve race condition in TestIntegration_CenterWeightedEnergy

Browse source 
The test was using the same HTTPBot instance for both players, causing
concurrent access to HTTPBot fields (turn, crashed, failCount, lastDebug).
Fixed by creating separate bot instances with different BotIDs.

This resolves the race detected by -race:
  WARNING: DATA RACE
  Write at 0x... by goroutine 475:
  github.com/aicodebattle/acb/engine.(*HTTPBot).GetMoves()
  Previous write at 0x... by goroutine 474:
  github.com/aicodebattle/acb/engine.(*HTTPBot).GetMoves()
This commit is contained in:
jedarden 2026-05-25 20:37:57 -04:00
parent e4cb9b8d43
commit 9647d7fb16
1 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
engine/integration_test.go
View file

@ -204,9 +204,6 @@ func TestIntegration_CenterWeightedEnergy(t *testing.T) {
server := createMockBotServer(t, secret, 0)
defer server.Close()
auth := AuthConfig{BotID: "b_test", Secret: secret, MatchID: "m_energy_test"}
bot := NewHTTPBot(server.URL, auth, WithHTTPTimeout(5*time.Second))
config := DefaultConfig()
config.Rows = 60
config.Cols = 60
@ -217,8 +214,14 @@ func TestIntegration_CenterWeightedEnergy(t *testing.T) {
WithTimeout(5*time.Second),
)
runner.AddBot(bot, "TestBot")
runner.AddBot(bot, "TestBot2")
// Use separate bot instances to avoid race conditions
auth1 := AuthConfig{BotID: "b_test1", Secret: secret, MatchID: "m_energy_test"}
bot1 := NewHTTPBot(server.URL, auth1, WithHTTPTimeout(5*time.Second))
auth2 := AuthConfig{BotID: "b_test2", Secret: secret, MatchID: "m_energy_test"}
bot2 := NewHTTPBot(server.URL, auth2, WithHTTPTimeout(5*time.Second))
runner.AddBot(bot1, "TestBot")
runner.AddBot(bot2, "TestBot2")
result, replay, err := runner.Run()
if err != nil {