jedarden/FABRIC
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
FABRIC/notes/bf-3oy5.md
jedarden cd24f596f7
Some checks are pending
CI / test (18.x) (push) Waiting to run
Details
CI / test (20.x) (push) Waiting to run
Details
CI / test (22.x) (push) Waiting to run
Details
docs(bf-3oy5): verify SemanticNarrativePanel tests passing 
Re-verified all 59 tests in SemanticNarrativePanel.test.ts pass.
The issue was already fixed in commit 6237010 (bf-48nk).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-22 16:38:55 -04:00

1.7 KiB
Raw Permalink Blame History

BF-3OY5: SemanticNarrativePanel Tests - Already Fixed

Issue

3 tests in src/tui/components/SemanticNarrativePanel.test.ts were reported as failing:

  • "should refresh narrative from manager"
  • "should generate narrative for worker and set it"
  • "should generate aggregated narrative and set it"

Root Cause

The tests were failing due to missing required fields in mock narrative objects. When the SemanticNarrative type was updated to require:

  • workerId: string
  • events: LogEvent[]
  • startTime: number
  • endTime: number
  • durationMs: number

The test mocks were not updated accordingly, causing type mismatches and runtime errors.

Fix Applied

The fix was already applied in commit 62370103685d6f629e7335d397c6dadb1c4cfe23:

  • Added all required fields to createMockNarrative() helper
  • Added missing fields to all inline narrative segment mocks throughout tests
  • Changed entities.workers array (incorrect) to workerId string (correct)

Verification

All 59 tests in SemanticNarrativePanel.test.ts now pass:

✓ src/tui/components/SemanticNarrativePanel.test.ts (59 tests) 37ms

Re-verified on 2026-05-22:

✓ src/tui/components/SemanticNarrativePanel.test.ts (59 tests) 110ms

The three specific tests mentioned in the issue:

  • ✓ "should refresh narrative from manager" - PASS
  • ✓ "should generate narrative for worker and set it" - PASS
  • ✓ "should generate aggregated narrative and set it" - PASS

The implementation methods (refresh(), updateFromWorker(), updateAggregated()) were always correct - they properly:

  1. Call the SemanticNarrative manager methods
  2. Pass results to setNarrative()
  3. Trigger render via this.box.screen.render()

The failure was purely a test data issue, not an implementation bug.