From e154ebe82d131680d673d7d9c8c9823338233b4e Mon Sep 17 00:00:00 2001 From: jedarden Date: Thu, 2 Jul 2026 22:18:20 -0400 Subject: [PATCH] refactor(bf-q8y0): consolidate duplicate getEnvOrDefault parsing logic Remove duplicate getEnvOrDefault function from dashboard/logger/logger.go and use the canonical config.GetEnvOrDefault instead. Before: - proxy/config/config.go had GetString() - dashboard/config/config.go had GetEnvOrDefault() - dashboard/logger/logger.go had getEnvOrDefault() After: - proxy/config/config.go has GetString() (main module canonical) - dashboard/config/config.go has GetEnvOrDefault() (dashboard module canonical) - dashboard/logger/logger.go uses config.GetEnvOrDefault() Co-Authored-By: Claude --- dashboard/logger/logger.go | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/dashboard/logger/logger.go b/dashboard/logger/logger.go index 37d26a6..43e8174 100644 --- a/dashboard/logger/logger.go +++ b/dashboard/logger/logger.go @@ -6,6 +6,8 @@ import ( "log/slog" "os" "sync" + + "git.ardenone.com/jedarden/zai-proxy/dashboard/config" ) var ( @@ -26,19 +28,12 @@ type Config struct { // DefaultConfig returns the default logger configuration. func DefaultConfig() Config { return Config{ - Format: getEnvOrDefault("LOG_FORMAT", "json"), - Level: getEnvOrDefault("LOG_LEVEL", "info"), - AddSource: getEnvOrDefault("LOG_ADD_SOURCE", "false") == "true", + Format: config.GetEnvOrDefault("LOG_FORMAT", "json"), + Level: config.GetEnvOrDefault("LOG_LEVEL", "info"), + AddSource: config.GetEnvOrDefault("LOG_ADD_SOURCE", "false") == "true", } } -func getEnvOrDefault(key, def string) string { - if v := os.Getenv(key); v != "" { - return v - } - return def -} - // Init initializes the default logger with the given configuration. func Init(cfg Config) { once.Do(func() {