docs(bf-26ta): correct blob literal counts, add missing ambient.test.js sites

Re-verified all blob-shaped object literals against current code. The prior
docs drifted: quick-actions.test.js was mis-counted as 16 literals (actual 5)
and only 4 of 6 ambient.test.js blob-array sites were documented.

Corrections (notes/bf-26ta-findings.md, bf-26ta-javascript-results.md):
- Add missing ambient.test.js sites at lines 694 (lerp source) and 708 (lerp target)
- Fix quick-actions.test.js count: 16 -> 5 literals (lines 208, 316, 470, 513, 678)
- Fix JS totals: 25 across 7 files -> 14 across 5 files
- state.js:290, websocket.js:167, replay.test.js:101 unchanged (still accurate)
- TypeScript: still 0 literals (only spaxel.d.ts type defs)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
jedarden 2026-07-06 09:29:02 -04:00
parent 756cc03a00
commit c595d13208
2 changed files with 37 additions and 9 deletions

View file

@ -6,9 +6,13 @@ This document catalogs all locations in the spaxel codebase where blob objects a
**Total Blob Creation Sites:**
- **Go:** 10 types, 20+ creation sites across 8 files
- **JavaScript:** 25 instances across 7 files
- **JavaScript:** 14 instances across 5 files
- **TypeScript:** 0 instances (type definitions only)
> **Note:** Counts re-verified against current code (2026-07-06). The previously reported
> "25 across 7 files" over-counted `quick-actions.test.js` (16 reported, 5 actual literals)
> and listed only 4 of the 6 `ambient.test.js` sites. Corrected totals below.
---
## TypeScript Findings
@ -55,7 +59,7 @@ export interface Blob {
### Search Results Summary
- **Total JavaScript files searched:** 80 (.js and .jsx files)
- **Blob-shaped object literals found:** 25 instances across 7 files
- **Blob-shaped object literals found:** 14 instances across 5 files
- **Primary creation pattern:** `dashboard/js/state.js:290`
### Detailed JavaScript Locations
@ -108,7 +112,17 @@ appState.blobs[id] = {
blobs: [{id: 1, x: 3, y: 3, z: 0, confidence: 0.8}]
```
**Pattern Types:** Full blob, Minimal blob, Position-only blob
- **Line 694-700:** Position blob at (1,1) — lerp source fixture
```javascript
blobs: [{id: 1, x: 1, y: 1, z: 0, confidence: 0.8}]
```
- **Line 708-714:** Position blob at (3,3) — lerp target fixture
```javascript
blobs: [{id: 1, x: 3, y: 3, z: 0, confidence: 0.8}]
```
**Pattern Types:** Full blob, Minimal blob, Position-only blob
**Context:** Test fixtures for 3D ambient floor plan renderer
---
@ -212,10 +226,10 @@ _blobStates.set(b.id, {
|------|------------|--------------|---------|
| `dashboard/js/state.js` | 1 | State initialization | Central state management |
| `dashboard/js/ambient.test.js` | 6 | Test fixtures | 3D ambient rendering tests |
| `dashboard/js/quick-actions.test.js` | 16 | Test fixtures | Spatial menu tests |
| `dashboard/js/quick-actions.test.js` | 5 | Test fixtures | Spatial menu tests |
| `dashboard/js/replay.test.js` | 1 | API mock | Session replay tests |
| `dashboard/js/websocket.js` | 1 | Derived state | Position extrapolation |
| **Total** | **25** | **Multiple patterns** | **5 files** |
| **Total** | **14** | **Multiple patterns** | **5 files** |
---

View file

@ -10,7 +10,11 @@ Search all JavaScript files (.js and .jsx) for blob-shaped object literals using
## Search Results Summary
### Blob-Shaped Object Literals Found: **25 instances across 7 files**
### Blob-Shaped Object Literals Found: **14 instances across 5 files**
> **Re-verified 2026-07-06:** previously reported "25 across 7 files" over-counted
> `quick-actions.test.js` (16 reported, 5 actual literals) and listed only 4 of the 6
> `ambient.test.js` sites. Corrected below.
---
@ -88,6 +92,16 @@ blobs: [{
}]
```
- **Line 694-700:** Position blob at (1,1) — lerp source fixture
```javascript
blobs: [{id: 1, x: 1, y: 1, z: 0, confidence: 0.8}]
```
- **Line 708-714:** Position blob at (3,3) — lerp target fixture
```javascript
blobs: [{id: 1, x: 3, y: 3, z: 0, confidence: 0.8}]
```
**Context:** Test fixtures for the 3D ambient floor plan renderer. These blobs represent detected people in 2D floor space for testing the ambient visualization system.
**Pattern Types:**
@ -359,10 +373,10 @@ const zone = {
|------|------------|--------------|---------|
| `dashboard/js/state.js` | 1 | State initialization | Central state management |
| `dashboard/js/ambient.test.js` | 6 | Test fixtures | 3D ambient rendering tests |
| `dashboard/js/quick-actions.test.js` | 16 | Test fixtures | Spatial menu tests |
| `dashboard/js/quick-actions.test.js` | 5 | Test fixtures | Spatial menu tests |
| `dashboard/js/replay.test.js` | 1 | API mock | Session replay tests |
| `dashboard/js/websocket.js` | 1 | Derived state | Position extrapolation |
| **Total** | **25** | **Multiple patterns** | **7 files** |
| **Total** | **14** | **Multiple patterns** | **5 files** |
---
@ -389,6 +403,6 @@ const zone = {
## Conclusion
The JavaScript codebase contains **25 blob-shaped object literals** across 7 files, with patterns ranging from minimal state initialization to comprehensive test fixtures. The canonical creation pattern is in `state.js:290`, while test files provide diverse blob structures for comprehensive coverage of rendering, interaction, and replay functionality.
The JavaScript codebase contains **14 blob-shaped object literals** across 5 files, with patterns ranging from minimal state initialization to comprehensive test fixtures. The canonical creation pattern is in `state.js:290`, while test files provide diverse blob structures for comprehensive coverage of rendering, interaction, and replay functionality.
**Blob detection pattern:** Look for objects with `{id, x, y, z}` core structure, optionally extended with identity, velocity, or confidence fields.