jedarden/spaxel
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: guard migration 7 ALTER TABLE with column existence check

Browse source 
SQLite doesn't support IF NOT EXISTS on ALTER TABLE ADD COLUMN.
The error_message and error_count columns already exist in the
triggers table from v0.1.33, causing migration 7 to fail on upgrade.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
jedarden 2026-04-12 17:27:11 -04:00
parent 22a5bfe561
commit 6bcd4711f1
1 changed files with 22 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
mothership/internal/db/migrations.go
View file

@ -460,12 +460,28 @@ func migration_006_add_virtual_node_columns(tx *sql.Tx) error {
// migration_007_add_webhook_tables adds webhook_log, trigger_state tables
// and error_message/error_count columns to the triggers table.
func migration_007_add_webhook_tables(tx *sql.Tx) error {
schema := `
-- Error tracking columns on triggers
ALTER TABLE triggers ADD COLUMN error_message TEXT DEFAULT '';
ALTER TABLE triggers ADD COLUMN error_count INTEGER NOT NULL DEFAULT 0;
cols := []struct {
name string
ddl string
}{
{"error_message", "ALTER TABLE triggers ADD COLUMN error_message TEXT DEFAULT ''"},
{"error_count", "ALTER TABLE triggers ADD COLUMN error_count INTEGER NOT NULL DEFAULT 0"},
}
for _, c := range cols {
var exists bool
if err := tx.QueryRow(
`SELECT COUNT(*) > 0 FROM pragma_table_info('triggers') WHERE name = ?`, c.name,
).Scan(&exists); err != nil {
return err
}
if !exists {
if _, err := tx.Exec(c.ddl); err != nil {
return err
}
}
}
-- Trigger blob state persistence across restarts
_, err := tx.Exec(`
CREATE TABLE IF NOT EXISTS trigger_state (
trigger_id INTEGER NOT NULL,
blob_id INTEGER NOT NULL,
@ -476,7 +492,6 @@ func migration_007_add_webhook_tables(tx *sql.Tx) error {
FOREIGN KEY (trigger_id) REFERENCES triggers(id) ON DELETE CASCADE
);
-- Webhook audit log
CREATE TABLE IF NOT EXISTS webhook_log (
id INTEGER PRIMARY KEY AUTOINCREMENT,
trigger_id INTEGER NOT NULL,
@ -488,8 +503,7 @@ func migration_007_add_webhook_tables(tx *sql.Tx) error {
FOREIGN KEY (trigger_id) REFERENCES triggers(id) ON DELETE CASCADE
);
CREATE INDEX IF NOT EXISTS idx_webhook_log_trigger ON webhook_log(trigger_id, fired_at_ms DESC);
`
_, err := tx.Exec(schema)
`)
return err
}