jedarden/pdftract

Fork 0

Commit graph

Author	SHA1	Message	Date
jedarden	d603e324a4	test(bf-5cnj8): add comprehensive CLI module imports for encryption testing Enhanced encryption test imports with additional diagnostic types: - Added DiagInfo import for structured diagnostic parsing - Added DIAGNOSTIC_CATALOG import for diagnostic validation Files modified: - crates/pdftract-cli/tests/test_encryption_errors.rs - crates/pdftract-cli/tests/test_encryption_unsupported.rs Both test files now have complete imports: use pdftract_cli::password; use pdftract_core::diagnostics::{DiagCode, DiagInfo, Severity, DIAGNOSTIC_CATALOG}; Acceptance criteria: ✅ CLI module imports added (use statements) ✅ Imports compile successfully ✅ Imports match actual crate structure Closes bf-5cnj8 Verification: notes/bf-5cnj8.md	2026-07-05 18:54:48 -04:00
jedarden	d0f52751ce	fix(pdftract-39gey): fix indent trigger to not split drop-cap paragraphs The indent trigger was using .abs() which fired on both increased indent (non-indented → indented) AND decreased indent (indented → non-indented). This caused drop-cap style paragraphs (indented first line, flush-left continuation) to incorrectly split into two blocks. Per plan Phase 4.4 heuristic #2, indent change should only trigger when the current line is MORE indented (to the right, larger x0) than the block average - i.e., a new paragraph starting after non-indented text. It should NOT trigger for decreased indent (first line indented, rest flush-left). Fix: Remove .abs() and only check if line_x0 - block_avg_x0 > threshold. Tests: - test_indented_first_line_new_block: PASS (non-indented → indented splits) - test_indented_first_line_of_paragraph_not_split: PASS (drop cap stays together) - All 179 line module tests: PASS	2026-06-07 13:43:19 -04:00

Author

SHA1

Message

Date

jedarden

d603e324a4

test(bf-5cnj8): add comprehensive CLI module imports for encryption testing

Enhanced encryption test imports with additional diagnostic types:
- Added DiagInfo import for structured diagnostic parsing
- Added DIAGNOSTIC_CATALOG import for diagnostic validation

Files modified:
- crates/pdftract-cli/tests/test_encryption_errors.rs
- crates/pdftract-cli/tests/test_encryption_unsupported.rs

Both test files now have complete imports:
use pdftract_cli::password;
use pdftract_core::diagnostics::{DiagCode, DiagInfo, Severity, DIAGNOSTIC_CATALOG};

Acceptance criteria:
✅ CLI module imports added (use statements)
✅ Imports compile successfully
✅ Imports match actual crate structure

Closes bf-5cnj8
Verification: notes/bf-5cnj8.md

2026-07-05 18:54:48 -04:00

jedarden

d0f52751ce

fix(pdftract-39gey): fix indent trigger to not split drop-cap paragraphs

The indent trigger was using .abs() which fired on both increased indent
(non-indented → indented) AND decreased indent (indented → non-indented).
This caused drop-cap style paragraphs (indented first line, flush-left
continuation) to incorrectly split into two blocks.

Per plan Phase 4.4 heuristic #2, indent change should only trigger when the
current line is MORE indented (to the right, larger x0) than the block
average - i.e., a new paragraph starting after non-indented text. It should
NOT trigger for decreased indent (first line indented, rest flush-left).

Fix: Remove .abs() and only check if line_x0 - block_avg_x0 > threshold.

Tests:
- test_indented_first_line_new_block: PASS (non-indented → indented splits)
- test_indented_first_line_of_paragraph_not_split: PASS (drop cap stays together)
- All 179 line module tests: PASS

2026-06-07 13:43:19 -04:00

2 commits