Commit graph

14 commits

Author SHA1 Message Date
jedarden
d603e324a4 test(bf-5cnj8): add comprehensive CLI module imports for encryption testing
Enhanced encryption test imports with additional diagnostic types:
- Added DiagInfo import for structured diagnostic parsing
- Added DIAGNOSTIC_CATALOG import for diagnostic validation

Files modified:
- crates/pdftract-cli/tests/test_encryption_errors.rs
- crates/pdftract-cli/tests/test_encryption_unsupported.rs

Both test files now have complete imports:
use pdftract_cli::password;
use pdftract_core::diagnostics::{DiagCode, DiagInfo, Severity, DIAGNOSTIC_CATALOG};

Acceptance criteria:
 CLI module imports added (use statements)
 Imports compile successfully
 Imports match actual crate structure

Closes bf-5cnj8
Verification: notes/bf-5cnj8.md
2026-07-05 18:54:48 -04:00
jedarden
a68d01c726 feat(bf-337i2): create 300 DPI invoice OCR fixture
Add invoice fixture with ground truth text for OCR testing.

Files:
- tests/fixtures/scanned/invoice/invoice-300dpi.pdf: 300 DPI scanned invoice
- tests/fixtures/scanned/invoice/invoice-300dpi-ground-truth.txt: complete text content
- tools/generate_invoice_pdf_fixtures.py: fixture generator script
- tests/fixtures/PROVENANCE.md: added provenance entries for new fixtures
- notes/bf-337i2.md: verification note

Verification:
- PDF is image-based (type=image, not text-embedded)
- Resolution: 300 DPI (x-ppi=300, y-ppi=300)
- Dimensions: 2550 x 3300 pixels (letter size at 300 DPI)
- Ground truth contains complete invoice text with headers, addresses, line items, totals

Closes bf-337i2
2026-07-05 18:20:09 -04:00
jedarden
7788719e0a docs(bf-ad2pp): analyze unmapped glyph fixture requirements
- Read design documents notes/bf-68f9i-design.md and notes/bf-68f9i-glyphs.md
- Identified 7 unmapped glyphs across 4 failure categories
- Identified 3 mapped AGL glyphs for comparison
- Verified existing generator implementation (gen_unmapped_comprehensive.rs)
- Confirmed fixture files exist and are correctly structured
- Documented implementation analysis in notes/bf-ad2pp.md

Closes bf-ad2pp
2026-07-03 19:17:02 -04:00
jedarden
6c668c7e42 docs(bf-ttbb5): document no-mapping.pdf generation verification
Successfully executed generate_unicode_recovery_fixtures_bin to create
no-mapping.pdf fixture (650 bytes). Validated PDF structure includes
custom /CustomNoMap font with /Differences encoding, non-AGL glyph
names, and no ToUnicode entry. Ground truth contains U+FFFD × 3.

Closes bf-ttbb5.
2026-07-03 16:13:27 -04:00
jedarden
990d73acf1 fix(bf-f0xqd): correct no-mapping.pdf ground truth to U+FFFD
The no-mapping.pdf fixture uses custom glyph names (/g001, /g002, /g003)
that are not in the Adobe Glyph List and cannot be recovered through any
Unicode recovery mechanism (no ToUnicode CMap, no standard encoding,
no AGL match).

The ground truth has been corrected from 'ABC' to three U+FFFD replacement
characters (���), which is the expected output when all encoding recovery
methods fail per the Failure Mode Taxonomy.

Also updated PROVENANCE.md with new SHA256 hashes for encoding fixtures
that were regenerated on 2026-07-02.

This fixture correctly exercises the ENCODING_NO_MAPPING failure mode as
specified in the plan (line 733).

Closes bf-f0xqd.
2026-07-03 15:55:29 -04:00
jedarden
26d622e2d8 docs(bf-3ourh): verify CJK fixtures exist and document in PROVENANCE
CJK fixtures and tests already exist from previous work:
- tests/fixtures/cjk/ contains all 4 required PDFs
- Ground truth files for each encoding (GB18030, Shift-JIS, EUC-KR, Big5)
- Tests in crates/pdftract-core/tests/cjk_encoding.rs and tests/test_encoding.rs
- Tests fail due to unimplemented CJK encoding (expected for Phase 2.3)
- Updated PROVENANCE.md with CJK fixture entries

Fixtures are ready for CJK encoding implementation.

Closes bf-3ourh
2026-06-24 12:35:47 -04:00
jedarden
b115b5a677 fix(bf-512z1): fix encoding fixture ground truth and add provenance
- no-mapping.txt: fix garbled unicode to correct 'ABC' output
- shape-match.txt: fix from 'Shape' to 'S' (actual PDF content)
- Add PROVENANCE.md entries for all 4 encoding fixtures
- PDFs remain unchanged (already valid)

Fixes ground truth for Level 2-4 Unicode recovery fixtures:
- no-mapping.pdf: PDF with no ToUnicode, no standard encoding
- agl-only.pdf: PDF with AGL glyph names only
- fingerprint-match.pdf: PDF with embedded font for fingerprint matching
- shape-match.pdf: PDF with subset font for shape recognition

Closes bf-512z1
2026-06-09 01:13:51 -04:00
jedarden
4dddd81bcd docs(pdftract-5o3zv): verify footnotes, inline links, and page breaks implementation
Phase 6.5.5 functionality already implemented and tested:
- Footnote emission infrastructure (PageFootnotes, emit_footnote_ref/def)
- Inline link emission (emit_page_links_from_json, emit_inline_link)
- Page breaks (--md-no-page-breaks CLI flag, MarkdownOptions)

All acceptance criteria tests pass. Ready for Phase 7 integration.

Also adds missing provenance entry for json_schema/simple-text.pdf fixture.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-01 16:00:12 -04:00
jedarden
96f5f80168 docs(profiles): add scanned fixtures to PROVENANCE.md
- Added 8 scanned fixture entries with SHA256 hashes
- Scanned fixtures: receipt, form, invoice, multi-page documents
- Generated by tests/fixtures/scanned/generate_scanned_fixtures.py
2026-06-01 09:25:53 -04:00
jedarden
fe59fa9785 feat(pdftract-47e42): implement URL fragment routing for shareable links
- Add #page=N URL fragment routing for shareable inspector links
- Support browser back/forward navigation via hashchange event
- Persist overlay toggle state in localStorage with error handling
- Add isUpdatingFragment flag to prevent double-render on hash updates
- Update thumbnail click handler to rely on updateFragment()
- Clamp out-of-range page numbers with console warnings
- Default to page 0 for invalid/non-numeric page numbers
- Add vector fixture provenance entries

Acceptance criteria:
- URL #page=14 on load → starts on page 14 ✓
- Navigate via next button → URL updates to #page=15 ✓
- Browser back button → URL and view update correctly ✓
- Bookmark with #page=14 → reopens to page 14 ✓
- Overlay toggles persist across page refresh ✓
- Out-of-range #page=999 → clamps to last page ✓
- Invalid #page=abc → defaults to page 0 ✓

Closes pdftract-47e42

Verification: notes/pdftract-47e42.md
2026-06-01 08:23:59 -04:00
jedarden
91e17d5029 docs(pdftract-35byi): update verification note with current fixture count
- Update fixture count from 1 to 5
- Add EC-04-rc4-encrypted.pdf, EC-05-aes128-encrypted.pdf, sample.pdf, valid-minimal.pdf
- All tests pass (6 passed, 1 ignored)
2026-06-01 02:38:31 -04:00
jedarden
5a737d0891 docs(pdftract-5ec94): add verification note for hover/search/JSON features
All three required features were already implemented:
- Hover tooltips with 50ms response (CSS transition:opacity 0s)
- JSON-tree click navigation with scroll + highlight
- Search filter UI with Enter cycling and Escape clear

Acceptance criteria: 6/6 PASS
2026-06-01 00:56:20 -04:00
jedarden
39ca6a3552 feat(pdftract-2b7ff): implement image_coverage_fraction signal evaluator
Add image_coverage_fraction signal evaluator that computes the union
image coverage fraction from individual image XObject areas.

- Computes total image coverage as sum of image_xobject_areas
- Divides by page area (width * height) to get coverage fraction
- Clamps to [0.0, 1.0] to handle overlapping images (defensive)
- Returns Some(Vote::scanned(0.85)) if fraction > 0.85

Implementation uses sum for simplicity (overestimates coverage when
images overlap), which is acceptable for the 0.85 threshold as it's
a conservative signal. Can be revisited with Klee's algorithm for
greater accuracy if needed.

Acceptance criteria PASS:
✓ Page with one image covering 90% area → Some(Vote { 0.85, Scanned })
✓ Page with multiple small images totaling 50% → None (below threshold)
✓ Page with no images → None
✓ Coverage clamped to 1.0 on overlapping images

Also includes pre-existing infrastructure:
- tr3_op_count field in PageContext
- image_xobject_areas field in PageContext
- all_tr3_with_full_page_image function
- CharDensityRatioSignal evaluator

These were necessary dependencies for the new evaluator to function.

Refs: Plan section Phase 5.1.2, coordinator pdftract-22p
2026-05-31 23:42:38 -04:00
jedarden
1dfaf73aa4 feat(pdftract-3g6ne): implement CMap codespace range parser
Some checks are pending
Schema Generation Validation / Validate JSON Schema (push) Waiting to run
Schema Generation Validation / Validate JSON Syntax (push) Waiting to run
This commit adds the codespace range parser for CMap streams. The parser
extracts the begincodespacerange / endcodespacerange blocks that define
legal byte-width boundaries for character codes in a CMap.

## Implementation

- CodespaceRange: Single range with lo/hi bounds (stored as [u8; 4]) and width (1-4 bytes)
- CodespaceRanges: Collection with SmallVec<[CodespaceRange; 8]>
- CodespaceParser: PostScript-style tokenizer for begincodespacerange blocks

## Acceptance Criteria (all PASS)

- Parse <00> <7F> → 1 range, width=1 
- Parse <00> <7F> <8000> <FFFF> in one block → 2 ranges 
- Width inference: 2-char hex → width=1; 4-char hex → width=2 
- Case-insensitive hex (<C0> and <c0> equivalent) 
- Malformed range (width mismatch) → diagnostic + skipped 
- Empty CMap → empty ranges 
- JIS range <8140> <FEFE> → 2-byte CJK 
- 3-byte and 4-byte range support 

Also adds encrypted fixture provenance entries to PROVENANCE.md.

Co-Authored-By: Claude Code <noreply@anthropic.com>
2026-05-28 05:47:07 -04:00