All necessary imports and test infrastructure are already in place:
- Standard library imports (fs, path, process)
- pdftract CLI imports (exit codes)
- pdftract Core imports (diagnostics, decryption errors)
- Test helpers (pdftract_bin, encrypted_fixture, assertion functions)
- Test modules (unsupported_handlers, exit_codes, password_handling, consistency)
File compiles successfully and all imports match actual crate structure.
Infrastructure was implemented in previous commit as part of bf-5for4.
Closes bf-2nl4x
- Ran all 6 forms_integration tests successfully
- Verified PDF fixture discovery works correctly
- Confirmed pdftract extract invocation pattern
- No orphaned processes or test hangs detected
- Tests are deterministic across multiple runs
- Scaffold ready for PDF fixtures to be added
Verification documented in notes/bf-614kj.md
- Add test_extract_all_discovered_pdfs() function to forms_integration.rs
- Use walkdir-based discover_pdf_fixtures() for recursive PDF discovery
- Spawn pdftract extract --json process for each PDF and capture output
- Print detailed status and output preview for debugging
- Fix pdftract_bin() path resolution (workspace target dir)
Closes bf-394lb. Verification: notes/bf-394lb.md. Tests: PASS (compiles, runs, no hangs).
- Add notes/bf-e4uvb-child-1.md with comprehensive documentation
- Mark ToUnicodeMap::add_mapping() in cmap.rs (line 86)
- Mark DifferencesOverlay entry creation in encoding.rs (line 195)
- Mark CodespaceRange creation in codespace.rs (line 256)
These are the critical insertion points for future unmapped glyph skip logic.
Closes bf-e4uvb-child-1.
- Add content target to fuzz/Cargo.toml
- Fix font fingerprint build script to use hex string keys instead of byte arrays
- Update fingerprint.rs to use hex string lookups
- Build verification: 54MB binary produced successfully
Acceptance criteria:
- ✅ cargo fuzz build content completes successfully
- ✅ No compilation errors or warnings
- ✅ Harness binary built and available
Closes bf-1c4f6
Fixed critical bug where validation script exited prematurely under
set -euo pipefail due to arithmetic operations returning non-zero exit
codes when evaluating to 0.
Changes:
- Replaced ((var++)) with var=$((var + 1))
- Replaced ((var += value)) with var=$((var + value))
- Restructured progress indicator to avoid modulo 0 result
Verification:
- Script now successfully validates all 1,260 corpus files
- Correctly reports 603 valid files with complete license info
- Detects 657 files with missing licenses (expected - PDFium test files)
- Exits with code 1 when validation fails (as designed)
Closes bf-632yt
- download-grep-corpus.sh now generates manifest.csv entries during download
- Implements SHA256 checksum computation via sha256sum
- Extracts page counts using pdfinfo
- Captures file sizes in bytes via stat
- Records source URLs for each downloaded file
- Appends entries to manifest.csv with all 6 required fields
- Handles incremental downloads (skips existing files, appends to manifest)
- Added grep-corpus-generate-manifest.sh helper for bootstrapping existing corpus
- Generated manifest entries for all 1,260 existing PDFs
- Verified checksum accuracy against actual files
Acceptance criteria:
- ✅ download-grep-corpus.sh writes manifest.csv entries for each downloaded PDF
- ✅ All 6 fields populated: filename, source_url, page_count, file_size, checksum, license
- ✅ Script handles incremental downloads (appends to existing manifest)
Closes bf-20fot
Verification: notes/bf-20fot.md
- Confirm ArgoCD sync status - templates exist in declarative-config
- Document commit hash (cb7b4f28) for traceability
- All acceptance criteria verified and met
- Fix /Differences array construction in generate_unmapped_glyphs.py
- Changed from '[code glyph code glyph ...]' to '[starting_code glyph1 glyph2 ...]' format
- All 7 unmapped glyphs from design spec now properly encoded without ToUnicode CMap
- Fixture validation passes: no ToUnicode, correct encoding format, all glyphs present
Closes bf-84xr8. Verification: notes/bf-84xr8.md
- Implement parameterized generator for unmapped glyph PDF fixtures
- Support custom glyph names via --glyphs JSON parameter
- Support custom font titles via --title parameter
- Include built-in test set matching design specification (notes/bf-68f9i-design.md)
- Generate valid PDF 1.4 with Type1 custom encoding
- Passes all acceptance criteria:
* Script exists in tests/fixtures/encoding/
* Accepts parameters for glyph names and encoding
* Generates valid PDF with specified structure
* Tested with dry runs (default and custom glyphs)
* Committed to git
Closes bf-3cwge
Examine the no-mapping.pdf test fixture using PDF analysis tools:
- pdfinfo: extracted metadata (1 page, 660 bytes, PDF 1.4, letter)
- pdffonts: identified CustomNoMap Type 1 font with custom encoding
- Documented structural findings for later reference
Key finding: fixture uses custom encoding with no embedding, designed to
test pdftract's handling of glyphs without standard Unicode mappings.
Closes bf-4ozvw.
Verified that existing documentation at tests/fixtures/no-mapping.md
comprehensively catalogs the 3 unmapped glyphs (g001, g002, g003)
with CID numbers and explanations for why they're unmapped.
All acceptance criteria met - documentation already complete from
previous bead bf-68f9i.
Closes bf-644ci
Successfully executed generate_unicode_recovery_fixtures_bin to create
no-mapping.pdf fixture (650 bytes). Validated PDF structure includes
custom /CustomNoMap font with /Differences encoding, non-AGL glyph
names, and no ToUnicode entry. Ground truth contains U+FFFD × 3.
Closes bf-ttbb5.
Add comprehensive research documentation for creating a PDF fixture
that tests the ENCODING_NO_MAPPING failure mode.
Covers:
- PDF specification for fonts without ToUnicode CMap
- Custom encoding approach using /Differences array
- Tooling and library options (manual construction, ReportLab, lopdf)
- Test text content specification
- Fixture structure validation
- Recovery level exercise confirmation
- Complete implementation examples in Rust and validation script
References:
- PDF 1.7 Specification (ISO 32000-1:2008)
- Adobe Glyph List (AGL)
- Internal docs: pdf-fonts-and-encoding.md, cmap-format-and-cid-encoding.md
Acceptance criteria met:
- [x] Documented approach exists in notes/bf-f0xqd-research.md
- [x] Approach specifies how to create a font with no ToUnicode CMap
- [x] Approach includes tooling/library requirements
- [x] Approach specifies test text content for the fixture
Closes bf-2g412
The no-mapping.pdf fixture uses custom glyph names (/g001, /g002, /g003)
that are not in the Adobe Glyph List and cannot be recovered through any
Unicode recovery mechanism (no ToUnicode CMap, no standard encoding,
no AGL match).
The ground truth has been corrected from 'ABC' to three U+FFFD replacement
characters (���), which is the expected output when all encoding recovery
methods fail per the Failure Mode Taxonomy.
Also updated PROVENANCE.md with new SHA256 hashes for encoding fixtures
that were regenerated on 2026-07-02.
This fixture correctly exercises the ENCODING_NO_MAPPING failure mode as
specified in the plan (line 733).
Closes bf-f0xqd.
CJK fixtures and tests already exist from previous work:
- tests/fixtures/cjk/ contains all 4 required PDFs
- Ground truth files for each encoding (GB18030, Shift-JIS, EUC-KR, Big5)
- Tests in crates/pdftract-core/tests/cjk_encoding.rs and tests/test_encoding.rs
- Tests fail due to unimplemented CJK encoding (expected for Phase 2.3)
- Updated PROVENANCE.md with CJK fixture entries
Fixtures are ready for CJK encoding implementation.
Closes bf-3ourh
