diff --git a/notes/bf-6066g.md b/notes/bf-6066g.md new file mode 100644 index 0000000..1aeb60e --- /dev/null +++ b/notes/bf-6066g.md @@ -0,0 +1,75 @@ +# Verification: resolver.rs Uses New Diagnostic Format + +**Bead ID:** bf-6066g +**Date:** 2026-07-06 +**Task:** Verify resolver.rs uses new diagnostic message format + +## Summary + +✅ **PASS** - All unmapped glyph assertions in `resolver.rs` use the new diagnostic format. + +## Findings + +### Unmapped Glyph Assertions: 1 found + +**Test:** `test_resolve_level2_unmapped_code` (lines 868-880) + +```rust +assert!( + result.is_failure(), + "Level 2 resolution should fail for unmapped character codes. \ + Expected: result.is_failure() == true. \ + Found: false. \ + Why this matters: Most codes in StandardEncoding above 0x7F are unmapped and should fail Level 2 (encoding + AGL) resolution per build/unmapped-glyph-names.json filtering." +); +``` + +### Format Verification + +The assertion correctly uses the new diagnostic message template: +- ✅ **Description:** "Level 2 resolution should fail for unmapped character codes." +- ✅ **Expected:** "result.is_failure() == true" +- ✅ **Found:** "false" +- ✅ **Why this matters:** "Most codes in StandardEncoding above 0x7F are unmapped..." + +### Count Verification + +- **Catalog (bf-1azpa):** 1 unmapped glyph assertion expected +- **Actual:** 1 unmapped glyph assertion found +- **Match:** ✅ Exact + +### Generic "assertion failed" Messages + +- ✅ **None found** - All unmapped glyph assertions use custom messages + +## Comparison with Catalog + +From `notes/bf-1azpa-catalog.md`: +- resolver.rs expected: 1 unmapped glyph assertion +- resolver.rs actual: 1 unmapped glyph assertion +- Status: ✅ MATCH + +## Total Assertions in resolver.rs + +The file contains 61 total assertions (including non-unmapped tests), but only 1 is specifically for unmapped glyph testing: +- **Unmapped glyph assertions:** 1 (updated with new format) +- **Other assertions:** 60 (out of scope for this verification) + +## Acceptance Criteria + +- ✅ All unmapped glyph assertions in resolver.rs use new message format +- ✅ No generic 'assertion failed' messages remain in unmapped tests +- ✅ Count matches expected from inventory (bf-1azpa catalog) + +## Conclusion + +**Status:** PASS ✅ + +All unmapped glyph assertions in `crates/pdftract-core/src/font/resolver.rs` have been successfully updated to use the new diagnostic message format. No generic assertion messages remain. + +--- + +**Verification completed:** 2026-07-06 +**File verified:** crates/pdftract-core/src/font/resolver.rs +**Total unmapped assertions:** 1 +**Generic assertions remaining:** 0