test(bf-5dopl): update resolver.rs assertion
This commit is contained in:
parent
89da30b3a5
commit
459f5addab
1 changed files with 47 additions and 0 deletions
47
notes/bf-1xtsk.md
Normal file
47
notes/bf-1xtsk.md
Normal file
|
|
@ -0,0 +1,47 @@
|
||||||
|
# Verification Note: bf-1xtsk
|
||||||
|
|
||||||
|
**Task:** Update resolver.rs assertion with new message
|
||||||
|
**Assertion:** 73 (test_resolve_level2_unmapped_code)
|
||||||
|
**Status:** VERIFIED - Already Updated
|
||||||
|
|
||||||
|
## Verification Details
|
||||||
|
|
||||||
|
### File: crates/pdftract-core/src/font/resolver.rs
|
||||||
|
|
||||||
|
**Test:** `test_resolve_level2_unmapped_code` (lines 868-880)
|
||||||
|
**Assertion:** Line 873-879
|
||||||
|
|
||||||
|
### Current Assertion Message (lines 875-878)
|
||||||
|
|
||||||
|
```rust
|
||||||
|
"Level 2 resolution should fail for unmapped character codes. \
|
||||||
|
Expected: result.is_failure() == true. \
|
||||||
|
Found: false. \
|
||||||
|
Why this matters: Most codes in StandardEncoding above 0x7F are unmapped and should fail Level 2 (encoding + AGL) resolution per build/unmapped-glyph-names.json filtering."
|
||||||
|
```
|
||||||
|
|
||||||
|
### Designed Message (bf-4kbre-messages.md, assertion 73)
|
||||||
|
|
||||||
|
```
|
||||||
|
"Level 2 resolution should fail for unmapped character codes. \
|
||||||
|
Expected: result.is_failure() == true. \
|
||||||
|
Found: false. \
|
||||||
|
Why this matters: Most codes in StandardEncoding above 0x7F are unmapped and should fail Level 2 (encoding + AGL) resolution per build/unmapped-glyph-names.json filtering."
|
||||||
|
```
|
||||||
|
|
||||||
|
## Acceptance Criteria Status
|
||||||
|
|
||||||
|
✅ **PASS:** Assertion 73 uses new message format
|
||||||
|
✅ **PASS:** No generic 'assertion failed' messages remain
|
||||||
|
✅ **PASS:** Assertion logic unchanged (still tests `result.is_failure()`)
|
||||||
|
✅ **PASS:** Message references build/unmapped-glyph-names.json as source of truth
|
||||||
|
✅ **PASS:** Message follows bf-300b5 template structure
|
||||||
|
|
||||||
|
## Conclusion
|
||||||
|
|
||||||
|
The assertion was already updated with the designed message from bf-4kbre-messages.md. No file changes were required. The bead bf-1xtsk is complete as the acceptance criteria are met.
|
||||||
|
|
||||||
|
**Verification Date:** 2026-07-06
|
||||||
|
**Verified By:** needle-worker
|
||||||
|
**Parent Bead:** bf-5dopl
|
||||||
|
**Message Source:** bf-w1o10 (designed in bf-4kbre-messages.md)
|
||||||
Loading…
Add table
Reference in a new issue