miroir/crates
jedarden a39b0e9df5 refactor(anti-entropy): remove dead with_mode_a_scaling and stale disabled-test comment (bf-no1g0)
The NOTE/TODO comment in tests/p13_8_anti_entropy.rs claimed a test
acceptance_4_mode_a_shard_partitioning existed-but-was-disabled due to an
API mismatch (with_mode_a_scaling). No such test lives in that file (it
jumps acceptance_3 -> bucket_isolation), and Mode A partitioning coverage
already lives inline in src/anti_entropy.rs (test_mode_a_anti_entropy_partitioning
plus the rendezvous minimal-reshuffling tests). Replaced the 4-line comment
with a one-line pointer to where the coverage actually lives.

Investigation also surfaced that with_mode_a_scaling itself is dead code:
the method is never called anywhere in the repo, and the fields it writes
(replica_group_id, num_pods) are write-only — never read. The live Mode A
scaling path routes through ModeACoordinator (with_mode_a_coordinator, read
in the run loop). Removed the method and its two orphaned fields.

Verified: grep for with_mode_a_scaling|acceptance_4_mode_a_shard_partitioning
under crates/ is empty; cargo build -p miroir-core succeeds; the external
p13_8_anti_entropy acceptance tests (8) pass.

Co-Authored-By: Claude <noreply@anthropic.com>
2026-07-10 16:35:13 -04:00
..
miroir-core refactor(anti-entropy): remove dead with_mode_a_scaling and stale disabled-test comment (bf-no1g0) 2026-07-10 16:35:13 -04:00
miroir-ctl feat(explain): display IncompleteIntegration warnings in CLI 2026-05-26 21:03:36 -04:00
miroir-proxy fix(ci): enable kafka-sink feature in CI build and Dockerfile 2026-05-31 12:08:39 -04:00