jedarden/miroir
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix integer overflow in anti-entropy fingerprint tests

Browse source 
Add bounds check to prevent subtraction overflow when offset exceeds
total_docs in test mocks for pagination tests.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
jedarden 2026-05-23 08:13:48 -04:00
parent 9009139b24
commit 46193cab60
1 changed files with 18 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
crates/miroir-proxy/tests/p5_8_a_anti_entropy_fingerprint.rs
View file

@ -156,6 +156,15 @@ async fn test_fingerprint_shard_pagination() {
let mut mock_client = MockTestNodeClient::new();
mock_client.expect_fetch_documents().returning(move |_, _, req| {
let start = req.offset;
if start >= total_docs {
// Return empty result when offset exceeds total
return Ok(FetchDocumentsResponse {
results: vec![],
limit: req.limit,
offset: req.offset,
total: total_docs as u64,
});
}
let end = std::cmp::min(req.offset + req.limit, total_docs);
let count = end - start;
@ -568,6 +577,15 @@ async fn test_fingerprint_config_batch_size() {
let mut mock_client = MockTestNodeClient::new();
mock_client.expect_fetch_documents().returning(move |_, _, req| {
let start = req.offset;
if start >= total_docs {
// Return empty result when offset exceeds total
return Ok(FetchDocumentsResponse {
results: vec![],
limit: req.limit,
offset: req.offset,
total: total_docs as u64,
});
}
let end = std::cmp::min(req.offset + req.limit, total_docs);
let count = end - start;