gap-review round 2: fix 22 gaps (6 high, 10 medium, 6 low)
High:
- G-1: Hook Installer §2 — single-quote validation for temp dir path now explicit
- G-2: large-prompt /read relay — encoding (UTF-8), response flow, and dedup of duplicate note
- G-3: State Machine — early Stop before prompt injection is now error (exit 2), not valid path
- G-4: stream-json reader — file-not-yet-exists retry loop (50ms, 5s timeout) specified
- G-5: Stop Poller /exit\r — explain no bracketed paste, 5s wait, fallback to SIGTERM
- G-6: PO-1 (--settings merge) verification moved to Phase 2 entry, removed from Phase 6
Medium:
- G-7: hook inheritance tests parameterized for --setting-sources= or --setting-sources=none
- G-8: Stop payload with no transcript_path AND no cwd — explicit error path added
- G-9: Event Loop §4 — dynamic fd registration (Vec<pollfd>, FIFO added at transition)
- G-10: Hook Inheritance section — add (OQ-1, unverified) caveat to --settings merge claim
- G-11: stream-json emits ALL raw lines (no dedup), matching claude -p behavior; noted for callers
- G-12: SIGTERM-to-SIGKILL 2s grace period adds to observed wall-clock timeout
- G-13: XTVERSION response — ambiguous backtick replaced with \x1bP>|claude-print\x1b\\
- G-14: mock_claude — SKIP_MOCK_CLAUDE=1 opt-out; --check resolves path relative to binary
- G-15: Phase 10 scope — clarified it adds only tests not written in Phases 2-9
Low:
- G-16: Hook Installer §2 — 0700 mode requirement now stated at component level
- G-17: --version flag — respects --claude-binary; defines fallback for claude-not-found
- G-18: cwd-slug ambiguity for hyphen-containing paths documented
- G-19: inherit_hooks = false in config triggers same --setting-sources= forwarding
- G-20: NEEDLE invoke_template max-turns 30 hardcodes over config.toml (noted)
- G-21: cost_usd always 0 — documented as known limitation
- G-22: Delivery section updated with all 4 artifacts (claude-print, mock_claude, yaml, install.sh)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1f64e37345