Bead bf-3mx7: Document winner badge fix completion

The code fix was already applied in commit 6fe778b. This commit
adds documentation noting that the index builder needs to be run
to regenerate static JSON with correct winner badges.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
jedarden 2026-05-13 17:58:54 -04:00
parent 9bcbd566b6
commit 770d704bc1
2 changed files with 22 additions and 1 deletions

View file

@ -1 +1 @@
0e6a4977b65041c402e1a5583ac3bd7d1312a6a0
6fe778be7840665b072a2fb47b55ae09a9a7dfcb

21
notes/bf-3mx7.md Normal file
View file

@ -0,0 +1,21 @@
# Bug Fix bf-3mx7: Match Index Winner Badge
## Problem
The match index winner badge was never showing because the `Won` field was incorrectly set using `p.BotID == m.WinnerID`. The issue: `m.WinnerID` is a player-slot integer as string (e.g. "2"), not a bot_id. The SQL query already computed the correct winner status in the `p.Won` field.
## Fix Applied
Fixed in commit `6fe778b` - Changed all occurrences from comparing `p.BotID == m.WinnerID` to using `p.Won` directly:
1. **matchToSummary** (line ~355): Changed `Won: p.BotID == m.WinnerID` to `Won: p.Won`
2. **buildPlaylistMatch** (line ~982): Changed `Won: p.BotID == m.WinnerID` to `Won: p.Won`
3. **ratingUpsetMagnitude**: Use `p.Won` to identify winner instead of comparing with `m.WinnerID`
4. **maxScoreDiff**: Use `p.Won` to identify winner instead of comparing with `m.WinnerID`
5. **isEvolutionBreakthrough**: Find winner using `p.Won` before checking if evolved
## Next Steps
To apply the fix to production data:
- Run the index builder to regenerate static JSON files with correct winner badges
- This requires database access and running: `go run cmd/acb-index-builder/main.go`
## Impact
This fixes the issue where 984/1000 production matches had `winner_id` set but all participants showed `won: false`.