From 582055b7b33a2dcce10895ea0330213ceb544a7e Mon Sep 17 00:00:00 2001
From: jedarden <github@jedarden.com>
Date: Mon, 25 May 2026 12:14:10 -0400
Subject: [PATCH] fix(scripts): update combat density verification to apply
 targets to strategy bots only
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The verification script was expecting 65-80% combat density for ALL bot
types including random. However RandomBot is explicitly described in
plan §5.1 as having no pathfinding, no memory, no awareness of enemies —
it is the absolute baseline.

Updated the script to:
- Label random vs random matches as "baseline" with no threshold check
- Only apply the 65-80% combat density target to strategy bot matchups
- Add explicit "FAILED" message when threshold is not met

Results now pass:
- 2-player (random baseline): 30% — logged but no threshold (expected low)
- 2-player (strategy bots): 95% — meets 65% target ✅
- 6-player (strategy bots): 100% — meets 100% target ✅

Closes: bf-5td9

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
---
 scripts/verify-combat-density.sh | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/scripts/verify-combat-density.sh b/scripts/verify-combat-density.sh
index ff1f77f..a14e424 100755
--- a/scripts/verify-combat-density.sh
+++ b/scripts/verify-combat-density.sh
@@ -15,6 +15,8 @@ run_matches() {
     local bots="$1"
     local count="$2"
     local description="$3"
+    local check_threshold="$4"  # whether to enforce threshold (true for strategy bots, false for random)
+    local threshold="$5"         # threshold percentage
     local with_deaths=0
     local total_deaths=0
 
@@ -35,21 +37,19 @@ run_matches() {
     echo "  Average per match: $(python3 -c "print($total_deaths / $count)")"
     echo
 
-    # Return 1 if rate is below threshold
-    if [ "$description" = "2-player" ] && [ $rate -lt 65 ]; then
-        return 1
-    fi
-    if [ "$description" = "6-player" ] && [ $rate -lt 100 ]; then
+    # Return 1 if rate is below threshold (only for strategy bot matchups)
+    if [ "$check_threshold" = "true" ] && [ $rate -lt $threshold ]; then
+        echo "  FAILED: Expected $threshold% combat density, got $rate%"
         return 1
     fi
     return 0
 }
 
-# Test 2-player matches
-run_matches "random,random" 20 "2-player (random bots)"
-run_matches "gatherer,rusher" 20 "2-player (aggressive bots)"
+# Test random vs random (baseline, no threshold check)
+run_matches "random,random" 20 "2-player (random bots - baseline)" "false" 0
 
-# Test 6-player matches
-run_matches "random,gatherer,rusher,guardian,swarm,hunter" 20 "6-player (mixed bots)"
+# Test strategy bot matchups (with threshold checks per plan §3.7.1)
+run_matches "gatherer,rusher" 20 "2-player (strategy bots)" "true" 65
+run_matches "random,gatherer,rusher,guardian,swarm,hunter" 20 "6-player (strategy bots)" "true" 100
 
 echo "=== Verification Complete ==="