Commit graph

4 commits

Author SHA1 Message Date
jedarden
47c3396e0c fix(bf-27e4): unify stuck detection metric with beadsCompleted
Some checks are pending
CI / test (18.x) (push) Waiting to run
CI / test (20.x) (push) Waiting to run
CI / test (22.x) (push) Waiting to run
Fix discrepancy where /api/workers returned contradictory data:
- beadsCompleted: 285 (counts bead.released events including timed-out)
- stuck: true, stuckReason: 'Running for 2311m with only 1 completion(s)'

The stuck detection now correctly uses:
- beadsCompleted: all beads processed (including timed-out/deferred)
- beadsSucceeded: only successful completions (bead.completed events)
- beadsTimedOut: new counter for timed-out/deferred beads

Changes:
- Add beadsTimedOut counter to WorkerInfo type
- Increment beadsTimedOut on bead.released with TimedOut/Deferred outcome
- Update stuck detection to show clear reason text:
  - 'X processed but 0 successful completions (all timed out/deferred)'
  - 'X processed but only Y successful completion(s) (Z timed out/deferred)'
- Add beadsTimedOut to evidence array

Fix acceptance criteria:
- Worker processing 100 timed-out beads shows clearly in UI:
  - 100 beads completed
  - 0 beads succeeded
  - Stuck reason: '100 processed but 0 successful completions'

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-07 11:11:50 -04:00
jedarden
9b5e740a92 test(bf-7x4z): fix 13 TypeScript type errors in test files
Some checks are pending
CI / test (18.x) (push) Waiting to run
CI / test (20.x) (push) Waiting to run
CI / test (22.x) (push) Waiting to run
- Add currentBead: null to all WorkerInfo test fixtures (8 files)
- Add missing required fields to SemanticNarrative test fixtures
  - accomplishments, challenges, sentiment, stats, generatedAt, isLive
- Add missing workerId and events to NarrativeSegment fixtures
- Fix onSelectCallback mock type assertion
- Add Record<string, string> index signature to mockBeadsData

All npx tsc --noEmit errors resolved. Test failures (6) remain
and are tracked in separate bead bf-40cu.

Closes: bf-7x4z
2026-05-26 17:11:47 -04:00
jedarden
cf7f727210 feat(bd-j1t): first-class worker state machine — NeedleState + gap-based stuck detection
Replace coarse NeedleWorkerStatus ('idle'|'executing'|'draining'|'starting')
with the real NEEDLE state machine: BOOTING→SELECTING→CLAIMING→WORKING→CLOSING→STOPPED.

- Add NeedleState type, VALID_TRANSITIONS map, needleStateToStatus() helper in types.ts
- Track needleState + lastStateTransition per worker by consuming worker.state_transition events
- Surface all six states in TUI worker cards (WorkerGrid, WorkerDetail) with per-state icons/colors
- Surface all six states in web WorkerGrid.tsx with NEEDLE_STATE_LABELS and NEEDLE_STATE_COLORS
- Add getNeedleStateColor/getNeedleStateIcon to colors.ts
- Rewire stuck detection to fire on state-transition gaps (state_gap pattern in stuckDetection.ts)
- Add sequence-based event ordering via compareEventsBySequence and queryOrdered()
- Legacy event-type fallback preserved for workers not emitting state_transition events

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-04-21 14:26:16 -04:00
jedarden
379883435b test(bd-1j9): Add E2E test for WorkerDetail panel
Verify WorkerDetail displays correct worker information including status
(active/idle/error), uptime formatting, beads completed count, last
activity details (bead, tool, duration, error), and recent events with
proper color tags and truncation.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-19 22:44:58 -04:00